patchFreeciv - Patches: patch #3481, en_US locale (to restore...

Show feedback again

patch #3481: en_US locale (to restore diacritics etc)

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Fri 03 Aug 2012 07:37:19 PM UTC  
Category: generalPriority: 3 - Low
Status: Need InfoPrivacy: Public
Assigned to: Emmet Hikory <persia>Open/Closed: Open
Planned Release: 2.6.0+others?Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):

You are not logged in

Please log in, so followups can be emailed to you.


(Jump to the original submission Jump to the original submission)

Thu 22 Oct 2015 02:55:24 AM UTC, comment #7:

> See patch #6451.

Note that patch #6451 only touches the gettext side. An en_US locale could still be useful if we want to use non ASCII characters in a C string literal msgid. See (The options -finput-charset, -fexec-charset and -fwide-exec-charset are GCC specific)

Sveinung Kvilhaugsvik <sveinung>
Project Member
Tue 20 Oct 2015 10:32:24 PM UTC, comment #6:

> (An alternative would be lifting the restriction that means
> msgids have to be ASCII-only. I don't know what that entails.)

See patch #6451.

Jacob Nevins <jtn>
Project Administrator
Fri 18 Jul 2014 02:46:16 AM UTC, comment #5:

Assuming it's safe to use UTF-8, done for trunk, as three patches:

diacritical-hint-cleanups.patch adds more diacriticals hints for Göktürk in hephthalite.ruleset (the Göktürks "crushed"the Hephthalites in our history), for Juárez in mexico.ruleset (we spelled his name correctly in zapotec.ruleset), and adusting the hint in salvadoran.ruleset so that Unicode matches Latin 1 (preferring the orthography selected in the Wikipedia article about El Salvador).

add-en_US-translation.patch adds support for en_US to our translations, and adds .po files for all the translation domains, with appropriate diacritical adjustments.

add-en_GB-diacriticals.patch adds all the diacriticals added in en_US to the current trunk en_GB translation (no other updates were applied to en_GB).

I don't know how much of this should be backported to S2_5 or S2_4, but would be happy to backport it, given direction. Also, while I'm up for providing and committing the initial en_US translation, my personal orthography isn't precisely en_US, so I'm unlikely to be a good maintainer if there are needs for changes beyond the restoration of diacriticals.

(file #21457, file #21458)

Emmet Hikory <persia>
Project MemberIn charge of this item.
Thu 17 Jul 2014 11:19:37 PM UTC, comment #4:

I've prepared an en_US translation (without diacriticals, but just `make ${PROJECT}.pot; msginit`). Unfortunately, the mentioned comments (I searched for `U+` appearing in comments) seem to assume there is a one-to-one relationship between a language domain and a character set, which isn't even true in Europe anymore (ISO-8859-1/ISO-8859-15/UTF-8/UCS2 are all very common), let alone places with more complex orthography.

Do we use bind_textdomain_codeset in a way that makes it safe for me to use UTF-8 representations in the translation (I'm happy to do en_GB at the same time, if this is the case)? Note that we appear to use UTF-8 in the rulesets for strings not subject to translation (e.g. city names, ruler names).

Alternately, is my understanding of gettext outdated? Is it now safe to declare a character set for msgid so that we may just use UTF-8 there?

Emmet Hikory <persia>
Project MemberIn charge of this item.
Mon 30 Jun 2014 04:00:40 PM UTC, comment #3:

Is there anyone active currently who remains opposed to this? There aren't that many strings to translate to en_US, so it seems relatively simple to do.

Emmet Hikory <persia>
Project MemberIn charge of this item.
Fri 03 Aug 2012 08:42:31 PM UTC, comment #2:

Previous discussion (PR #39642) archived on Aug 2007, Sep 2007.

Jacob Nevins <jtn>
Project Administrator
Fri 03 Aug 2012 08:12:27 PM UTC, comment #1:

For the record: I once suggested adding en_US.po for fixing typos etc during string freeze. Idea was shot down. Anyway, those opposing the idea back then are no longer involved with Freeciv, so I don't think that decision is binding us any more. That original discussion was lost with RT, I think.

Marko Lindqvist <cazfi>
Project Administrator
Fri 03 Aug 2012 07:37:19 PM UTC, original submission:

In a number of places (notably nations), there are plain ASCII renderings of names/words with diacritics etc with i18n marking, accompanied with TRANS comments instructing translators where to reinstate the non-ASCII characters.

This means English players miss out on correct orthography. I could fix this for en_GB players in the po file (but haven't).

Any reason we couldn't supply an en_US locale whose only job was to restore the orthography? (It's possible this could even be done mechanically, although I'm not sure how it would work exactly.)

(An alternative would be lifting the restriction that means msgids have to be ASCII-only. I don't know what that entails.)

Jacob Nevins <jtn>
Project Administrator


(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):

Attached Files
file #21459:  add-en_US-translation.patch.gz added by persia (355kB - application/octet-stream)
file #21457:  diacritical-hint-cleanups.patch added by persia (3kB - application/octet-stream)
file #21458:  add-en_GB-diacriticals.patch added by persia (23kB - application/octet-stream)


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -unavailable- added by sveinung (Posted a comment)
  • -unavailable- added by persia (Posted a comment)
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by jtn (Submitted the item)

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.


    Error: not logged in



    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 18 Jul 2014 02:48:09 AM UTCpersiaAttached File-=>Added add-en_US-translation.patch.gz, #21459
    Fri 18 Jul 2014 02:46:16 AM UTCpersiaAttached File-=>Added diacritical-hint-cleanups.patch, #21457
      Attached File-=>Added add-en_GB-diacriticals.patch, #21458
      StatusNone=>Need Info
      Assigned toNone=>persia
      Planned Release=>2.6.0+others?
    Show feedback again

    Back to the top

    Powered by Savane 3.1-cleanup