patchFreeciv - Patches: patch #3483, The way default tileset is selected

 
 
Show feedback again

patch #3483: The way default tileset is selected

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Sun 05 Aug 2012 09:35:16 PM UTC  
 
Category: clientPriority: 5 - Normal
Status: NonePrivacy: Public
Assigned to: NoneOpen/Closed: Open
Planned Release: 

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 23 Feb 2013 08:28:50 AM UTC, comment #1:

> Now that default tileset selection by priority is fixed


That would be bug #20008, except that fix was never even submitted. By above I probably meant that this ticket was opened when I were testing local fix for bug #20008.

Marko Lindqvist <cazfi>
Project Administrator
Sun 05 Aug 2012 09:35:16 PM UTC, original submission:

Now that default tileset selection by priority is fixed (it was selecting first in alphabetical order) it became even more apparent that this needs to be rethought.

The selection does not discriminate between sources where tileset is from - it's not necessarily one of the tilesets we ship with. I just got ancients tileset when launching new installation (freeciv-modpack used first to grab custom modpacks), which even isn't compatible with default rulesets.
The problem is not caused by the priority fix - but when selecting by alphabetical order, there wasn't any (widely used) tilesets before "Amplio".

So, I think we should get rid of the priority concept, and provide name of the default tileset in code. To make future migrations to new default tilesets to work better, special value "default" similar to metaserver setting should be used.

Anyway, while we wait for freeciv fix for general case, quickfix to reduce ancients tileset priority should prevent it from claiming default tileset status in more installations. I'll update versions available via freeciv-modpack asap.

Marko Lindqvist <cazfi>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    No Changes Have Been Made to This Item
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup