patchFreeciv - Patches: patch #3523, Start page updated

Show feedback again

patch #3523: Start page updated

Submitted by:  mir3x <mir3x>
Submitted on:  Sat Sep 8 16:28:09 2012  
Category: client-qtPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.5.0Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):

You are not logged in

Please log in, so followups can be emailed to you.


(Jump to the original submission Jump to the original submission)

Fri Feb 8 23:06:07 2013, comment #6:

OOps, sorry, my client puts it sometimes automatically, I always try to remove it. I have no idea why its there , pls remove it

mir3x <mir3x>
Project Member
Fri Feb 8 23:02:31 2013, SVN revision 22313:

Qt-client start page updated

- Added nation selection dialog
- Added context menu for players

Patch by mir3x

See gna patch #3523

(Browse SVN revision 22313)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri Feb 8 22:47:27 2013, comment #4:

The only problem with this is include of gui-sdl/mmx.h. Gui sources really shouldn't depend on each other. I'm not going to hold this patch for that detail, though. It just needs to be fixed soon afterwards. I'll submit patch to move mmx.h to client common headers later tonight.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu Feb 7 01:13:00 2013, comment #3:

Fixed, also tabwidget replaced with treewidget for better view

(file #17147)

mir3x <mir3x>
Project Member
Sun Oct 7 04:07:32 2012, comment #2:

- Once I select nation, same leader name is shown in "Name" and "Leader" columns. I suppose former should remain as user name.
- Observers are listed after all players, not next to one (s)he observes. There's no easy way to tell who I'm observing
- Do we really need two different "random nation" concepts? Originally everyone has "Random" nation meaning they will be assigned random nation when game starts. If I then pick "Random", I get immediately assigned some nation and there's no way of getting back to original random-as-unassigned state.
- For usability it would be nice if "Take this player" would toggle AIness of the player off. I take the player because I want to play it (otherwise I would select observing)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri Oct 5 05:46:30 2012, comment #1:

- Replaced #includes with simple class forward declarations when possible
- Comment typofix

Qt-client does not work (with or without this patch) on this computer at the moment, so I've not yet tested this patch at all.

(file #16641)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat Sep 8 16:28:09 2012, original submission:

Added nation selection dialog
Added context menu for players in start page
Rearranged layout in start page, some older code was replaced
( switching pages, what leaded to some minor changes )

mir3x <mir3x>
Project Member


(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):

Attached Files
file #17147:  QtStartPage-3.patch.bz2 added by mir3x (9kB - application/bzip2)
file #16641:  QtStartPage-2.patch.bz2 added by cazfi (8kB - application/x-bzip)
file #16491:  QtStartPage.patch.bz2 added by mir3x (8kB - application/bzip2)


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -unavailable- added by cazfi (Updated the item)
  • -unavailable- added by mir3x (Submitted the item)

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.


    Error: not logged in



    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri Feb 8 23:02:58 2013cazfiStatusReady For Test=>Done
      Assigned toNone=>cazfi
    Thu Feb 7 01:13:00 2013mir3xAttached File-=>Added QtStartPage-3.patch.bz2, #17147
    Fri Oct 5 05:46:30 2012cazfiAttached File-=>Added QtStartPage-2.patch.bz2, #16641
      StatusNone=>Ready For Test
      Planned Release=>2.5.0
    Sat Sep 8 16:28:09 2012mir3xAttached File-=>Added QtStartPage.patch.bz2, #16491
    Show feedback again

    Back to the top

    Powered by Savane 3.1-cleanup