patchBattle for Wesnoth - Patches: patch #3527, Add quick switch button for...

 
 
Show feedback again

patch #3527: Add quick switch button for recruit/recall

Submitted by:  David Mikos <coffee>
Submitted on:  Sun 30 Sep 2012 08:42:45 AM UTC  
 
Priority: 3 - LowStatus: None
Privacy: PublicAssigned to: Ignacio R. Morelle <shadowmaster>
Open/Closed: Open

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 10 Mar 2013 09:40:30 PM UTC, comment #5:

A follow up with the problem I have with this.

The button works great unless you select a unit from the recruit/recall list -- then it disappears. I am not sure how to make it so that the left side of the frame does not refresh over the top of the new button. Any pointers on where to look?

David Mikos <coffee>
Project Member
Wed 03 Oct 2012 08:20:59 PM UTC, comment #4:

Also, you need to add yourself to Miscellaneous Contributors in data/core/about.cfg, and add relevant entries for the changelog and players_changelog.

Ignacio R. Morelle <shadowmaster>
Project AdministratorIn charge of this item.
Wed 03 Oct 2012 09:00:57 AM UTC, comment #3:

I like this idea. I guess it might be even more useful when dealing with multiple leaders with distinct recruit and/or recall lists.

I took a look at the patch and found a few things, though:

One hunk adds a blank line with a trailing tabstop to src/construct_dialog.cpp. That should be removed.

Another hunk adds a commented out line to the same file around line 483:
The BUTTON_FULL_LEFT enum member does not have the same value as BUTTON_EXTRA_LEFT, so the code flow here actually leads to the default case with the commented out case. If this is intentional, then the commented out line doesn't really belong to the case chain handling BUTTON_EXTRA_LEFT and BUTTON_CHECKBOX_LEFT.

A hunk adds the following in src/menu_events.cpp around line 1057:

The whitespace between the method name and the argument list's opening parenthesis needs to go.

Other than that, this looks good enough for me to commit.

Ignacio R. Morelle <shadowmaster>
Project AdministratorIn charge of this item.
Sun 30 Sep 2012 11:54:47 PM UTC, comment #2:

Aligned to left in v2 patch.

Here I have added a new BUTTON_FULL_LEFT alignment.

This alignment goes to the left and the bottom, then up on each one before it. This needed to be done because no other preexisting button layout does this.

This has the side benefit of being able to be used instead of "delete save" from the load save screen, where currently a help layout and associated help pointer is used for this. However, this I left out of the patch.

(file #16616)

David Mikos <coffee>
Project Member
Sun 30 Sep 2012 06:03:51 PM UTC, comment #1:

The extra buttons should be aligned either to the left or the right edge, having them floating in the middle looks very bad imho.

B. Lipka <lipk>
Project Member
Sun 30 Sep 2012 08:42:45 AM UTC, original submission:

Attached is a patch to add an extra button to quickly go between recruit and recall.

The idea is very simple:
- a "recall list" button will appear underneath the recruits menu if there is an available recall
- a "recruit list" button will be available from the recall menu (left of "dismiss unit")

This makes it easier to go between the 2 menus (and not forget if there is a recall available in campaigns)

David Mikos <coffee>
Project Member

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #16616:  recruit_recall_patch_v2 added by coffee (6kB - application/octet-stream)
file #16614:  recruit_recall_patch added by coffee (3kB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by shadowmaster (Updated the item)
  • -unavailable- added by lipk (Posted a comment)
  • -unavailable- added by coffee (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 03 Oct 2012 08:40:45 AM UTCshadowmasterAssigned toNone=>shadowmaster
    Sun 30 Sep 2012 11:54:47 PM UTCcoffeeAttached File-=>Added recruit_recall_patch_v2, #16616
    Sun 30 Sep 2012 08:42:46 AM UTCcoffeeAttached File-=>Added recruit_recall_patch, #16614
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup