patchFreeciv - Patches: patch #3539, Scorelog: new tags and details

 
 
Show feedback again

patch #3539: Scorelog: new tags and details

Submitted by:  Davide Baldini <davide_at_debian>
Submitted on:  Mon Oct 8 12:36:19 2012  
 
Category: generalPriority: 5 - Normal
Status: NonePrivacy: Public
Assigned to: NoneOpen/Closed: Open
Planned Release: Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Fri Jul 11 01:02:43 2014, comment #9:

As things stand, my review comments have gone unanswered, there's no users for the new format, and the change might break old users. No point in including this to 2.5, nor is there known need for any specific future release. Let's remove the target release - we return to this issue when we do.

Marko Lindqvist <cazfi>
Project Administrator
Wed Jul 2 23:42:45 2014, comment #8:

If we're going to apply this, we should probably do so before 2.5.0-beta1, so we don't have multiple 2.5 scorelog formats around.

Jacob Nevins <jtn>
Project Administrator
Mon Apr 1 23:11:18 2013, comment #7:

I have tools to process the new scorelog format.
If you are interested to see how they work, I have created this thread to answer the question.

Davide Baldini <davide_at_debian>
Mon Apr 1 20:58:45 2013, comment #6:

I'd like to have this one finished to conclude scorelog changes for 2.5.

Do you happen to already have any utilities to process these new scorelog formats?

Marko Lindqvist <cazfi>
Project Administrator
Fri Nov 16 01:06:53 2012, comment #5:

- Also doc/README.scorelog should be updated

Marko Lindqvist <cazfi>
Project Administrator
Thu Nov 15 23:32:33 2012, comment #4:

- New functions with empty function header are no longer accepted. Please add function header for the functions you are adding
- in one comment you change "iff" (if and only if) to "if" Is that correct (can the function sometimes return TRUE even if reading the file failed)?

Marko Lindqvist <cazfi>
Project Administrator
Wed Oct 10 14:03:50 2012, comment #3:

I realized that the new entry "ranked_username" in the scorelog file introduced by this patch would serve no purpose since at the time it is logged, as payload of the "addplayer" directive, the associated player has just joined the game, and hence TURNS_NEEDED_TO_RANK turns have not yet passed, which is required to set the variable "ranked_username" to the player's username from its default ANON_USERNAME.

I removed "ranked_username" from the "addplayer" directive; format is:
addplayer <turn> <player-id> <name> , <username>
adds a player starting at the given turn (inclusive)
<player-id> is a number which can be reused
<name> may contain whitespaces
<username> may contain whitespaces

(file #16684)

Davide Baldini <davide_at_debian>
Tue Oct 9 06:26:58 2012, comment #2:

> Freeciv 2.3.2.


Not strictly a bugfix, and more importantly changes file format potentially breaking existing tools parsing it, so cannot be accepted to stable brances. Setting 2.5 target.

Marko Lindqvist <cazfi>
Project Administrator
Mon Oct 8 12:42:41 2012, comment #1:

Previous message is best read formatted here.

Davide Baldini <davide_at_debian>
Mon Oct 8 12:36:19 2012, original submission:

I introduced these tags to the scorelog file:
taxout: gold accumulated per turn;
cunits: amount of civilian units owned.

The scorelog command "addplayer" now logs "username" and "ranked_username", in addition to player's "name"; it's format becomes:
addplayer <turn> <player-id> <name> , <username> , <ranked_username>
adds a player starting at the given turn (inclusive)
<player-id> is a number which can be reused
<name> may contain whitespaces
<username> may contain whitespaces
<ranked_name> may contain whitespaces

The white space preceding commas is taken in consideration of sscanf() in report.c, line 1129, Freeciv 2.3.2.

Patch has been tested.

Davide Baldini <davide_at_debian>

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jtn (Posted a comment)
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by davide_at_debian (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Error: not logged in

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri Jul 11 01:02:43 2014cazfiPlanned Release2.5.0-beta1=>
    Wed Jul 2 23:42:45 2014jtnPlanned Release2.5.0=>2.5.0-beta1
    Mon Apr 1 20:58:45 2013cazfiStatusReady For Test=>None
    Wed Oct 10 14:03:50 2012davide_at_debianAttached File-=>Added scorelog_detailed-1.patch, #16684
    Tue Oct 9 06:26:58 2012cazfiStatusNone=>Ready For Test
      Planned Release=>2.5.0
    Mon Oct 8 12:36:19 2012davide_at_debianAttached File-=>Added scorelog_detailed-2.3.2.patch, #16673
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup