patchFreeciv - Patches: patch #3539, Scorelog: new tags and details

 
 
Show feedback again

patch #3539: Scorelog: new tags and details

Submitted by:  Davide Baldini <davide_at_debian>
Submitted on:  Mon 08 Oct 2012 12:36:19 PM UTC  
 
Category: generalPriority: 5 - Normal
Status: NonePrivacy: Public
Assigned to: NoneOpen/Closed: Open
Planned Release: 

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Fri 11 Jul 2014 01:02:43 AM UTC, comment #9:

As things stand, my review comments have gone unanswered, there's no users for the new format, and the change might break old users. No point in including this to 2.5, nor is there known need for any specific future release. Let's remove the target release - we return to this issue when we do.

Marko Lindqvist <cazfi>
Project Administrator
Wed 02 Jul 2014 11:42:45 PM UTC, comment #8:

If we're going to apply this, we should probably do so before 2.5.0-beta1, so we don't have multiple 2.5 scorelog formats around.

Jacob Nevins <jtn>
Project Administrator
Mon 01 Apr 2013 11:11:18 PM UTC, comment #7:

I have tools to process the new scorelog format.
If you are interested to see how they work, I have created this thread to answer the question.

Davide Baldini <davide_at_debian>
Mon 01 Apr 2013 08:58:45 PM UTC, comment #6:

I'd like to have this one finished to conclude scorelog changes for 2.5.

Do you happen to already have any utilities to process these new scorelog formats?

Marko Lindqvist <cazfi>
Project Administrator
Fri 16 Nov 2012 01:06:53 AM UTC, comment #5:

- Also doc/README.scorelog should be updated

Marko Lindqvist <cazfi>
Project Administrator
Thu 15 Nov 2012 11:32:33 PM UTC, comment #4:

- New functions with empty function header are no longer accepted. Please add function header for the functions you are adding
- in one comment you change "iff" (if and only if) to "if" Is that correct (can the function sometimes return TRUE even if reading the file failed)?

Marko Lindqvist <cazfi>
Project Administrator
Wed 10 Oct 2012 02:03:50 PM UTC, comment #3:

I realized that the new entry "ranked_username" in the scorelog file introduced by this patch would serve no purpose since at the time it is logged, as payload of the "addplayer" directive, the associated player has just joined the game, and hence TURNS_NEEDED_TO_RANK turns have not yet passed, which is required to set the variable "ranked_username" to the player's username from its default ANON_USERNAME.

I removed "ranked_username" from the "addplayer" directive; format is:
addplayer <turn> <player-id> <name> , <username>
adds a player starting at the given turn (inclusive)
<player-id> is a number which can be reused
<name> may contain whitespaces
<username> may contain whitespaces

(file #16684)

Davide Baldini <davide_at_debian>
Tue 09 Oct 2012 06:26:58 AM UTC, comment #2:

> Freeciv 2.3.2.


Not strictly a bugfix, and more importantly changes file format potentially breaking existing tools parsing it, so cannot be accepted to stable brances. Setting 2.5 target.

Marko Lindqvist <cazfi>
Project Administrator
Mon 08 Oct 2012 12:42:41 PM UTC, comment #1:

Previous message is best read formatted here.

Davide Baldini <davide_at_debian>
Mon 08 Oct 2012 12:36:19 PM UTC, original submission:

I introduced these tags to the scorelog file:
taxout: gold accumulated per turn;
cunits: amount of civilian units owned.

The scorelog command "addplayer" now logs "username" and "ranked_username", in addition to player's "name"; it's format becomes:
addplayer <turn> <player-id> <name> , <username> , <ranked_username>
adds a player starting at the given turn (inclusive)
<player-id> is a number which can be reused
<name> may contain whitespaces
<username> may contain whitespaces
<ranked_name> may contain whitespaces

The white space preceding commas is taken in consideration of sscanf() in report.c, line 1129, Freeciv 2.3.2.

Patch has been tested.

Davide Baldini <davide_at_debian>

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jtn (Posted a comment)
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by davide_at_debian (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 11 Jul 2014 01:02:43 AM UTCcazfiPlanned Release2.5.0-beta1=>
    Wed 02 Jul 2014 11:42:45 PM UTCjtnPlanned Release2.5.0=>2.5.0-beta1
    Mon 01 Apr 2013 08:58:45 PM UTCcazfiStatusReady For Test=>None
    Wed 10 Oct 2012 02:03:50 PM UTCdavide_at_debianAttached File-=>Added scorelog_detailed-1.patch, #16684
    Tue 09 Oct 2012 06:26:58 AM UTCcazfiStatusNone=>Ready For Test
      Planned Release=>2.5.0
    Mon 08 Oct 2012 12:36:19 PM UTCdavide_at_debianAttached File-=>Added scorelog_detailed-2.3.2.patch, #16673
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup