patchFreeciv - Patches: patch #3560, Use standard button interface...

 
 
Show feedback again

patch #3560: Use standard button interface (patch 21/60)

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Tue 13 Nov 2012 11:44:59 PM UTC  
 
Category: client-gtk-3.0Priority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sun 20 Oct 2013 11:12:49 AM UTC, comment #10:

I'm currently carrying the attached local patch to relax the Gtk 3.6.0 requirement, so I can work with the Gtk3 client on trunk (Ubuntu 12.04 only has 3.4.2-0ubuntu0.5).

Not suggested for commit in its current form, but is there any interest in committing something like this in some form? We currently have no other dependence on >=3.6.0 (although I'm sure we'll get a more substantial dependency at some point). If so I can raise a new ticket.

(For what it's worth, the button image appeared with all the themes on my system, including the Freeciv theme.)

(file #19213)

Jacob Nevins <jtn>
Project Administrator
Mon 03 Jun 2013 09:37:02 PM UTC, SVN revision 22931:

Use standard gtk3 button interface in governor.
Made version 3.6 of gtk minimum requirement of gtk3-client.

Patch by Rafa?\197?\130 Mu?\197?\188y?\197?\130o and myself

See patch #3560

(Browse SVN revision 22931)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu 30 May 2013 09:26:44 PM UTC, comment #8:

Version that makes gtk+ 3.6 minimum requirement, and uses gtk_button_set_always_show_image(). Meant for TRUNK only.

(file #18033)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu 30 May 2013 08:55:14 PM UTC, comment #7:

From patch #3889:

> One other thing regarding patch #3560:
> while there is gtk_button_set_always_show_image, it's only since > 3.6 and IMHO title of the button is descriptive enough in the
> context anyway if one has a theme that turns off images on
> buttons.


Could that be the thing to do in development version even though it cannot be solution for S2_4. Make gtk+-3.6 minimum requirement, and use gtk_button_set_always_show_image().

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 04 May 2013 08:08:59 AM UTC, comment #6:

It's not about whether one can understand what the button says, but about always noticing it, subconsciously at least. With just the button text one may quickly changes the other settings without looking if this "master switch" actually makes the (correct) changes to take effect.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri 03 May 2013 06:09:14 PM UTC, comment #5:

As with any other gtk-setting, gtk-button-images can be set in settings.ini accompanying gtk.css.
Though I stand by what I wrote in patch #3889 (and a few other places) on this topic.

Rafał Mużyło <galtgendo>
Wed 01 May 2013 06:18:35 PM UTC, comment #4:

> Well, we could just set this to true in the theme.


Sorry, I had (probably) misinterpreted this earlier. You mean it's just change in Freeciv theme to make the image visible again?

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 17 Nov 2012 02:49:37 AM UTC, comment #3:

Well, we could just set this to true in the theme.

Note, that there are other places already affected by this setting - that screenshot in patch #3561 suggests you didn't notice that.

Rafał Mużyło <galtgendo>
Fri 16 Nov 2012 11:34:40 PM UTC, comment #2:

> As it's a standard button now, it follows the theme.


Uhm. Maybe the whole point of not having it as standard button earlier was that it's better with glaring indicator of governor state. With this patch it has just the text.

Can you list some pros (and cons) for this patch?

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 14 Nov 2012 02:07:41 AM UTC, comment #1:

Actually, that probably means it does work.

The answer may lie in "gtk-button-images" from GtkSettings.
As it's a standard button now, it follows the theme.

Rafał Mużyło <galtgendo>
Tue 13 Nov 2012 11:44:59 PM UTC, original submission:

This ticket is about handling patch 21/60 (Use standard button interface) from Rafał Mużyło's patchset in patch #3469

I tested this patch, and it seems that the red/green icon from the golvernor on/off button disappears with the patch.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #19213:  trunk-allow-gtk-34x.patch added by jtn (3kB - text/x-diff - trunk r23597: temporary patch to allow compilation with Gtk 3.4.x)
file #18033:  Gtk3StdButIface.patch added by cazfi (5kB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jtn (Updated the item)
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 20 Oct 2013 11:12:49 AM UTCjtnAttached File-=>Added trunk-allow-gtk-34x.patch, #19213
    Mon 03 Jun 2013 09:37:38 PM UTCcazfiStatusReady For Test=>Done
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Thu 30 May 2013 09:26:44 PM UTCcazfiAttached File-=>Added Gtk3StdButIface.patch, #18033
      StatusNone=>Ready For Test
      Planned Release2.5.0=>2.6.0
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup