Freeciv - Patches: patch #3560, Use standard button interface... [Gna!]

Freeciv - Patches: patch #3560, Use standard button interface...

Group

Main
- Main
- View Members
- Search
Homepage
Download
Docs
- Browse
- Submit
- Edit
- Digest
- Export
- Search
Mailing Lists
Source Code
- Use Subversion
- Browse Sources Repository
Bugs
- Browse
- Reset to all open ones
- Submit
- Digest
- Export
- View Statistics
- Search
Tasks
- Browse
- Reset to all open ones
- Submit
- Digest
- Export
- View Statistics
- Search
Patches
- Browse
- Reset to all open ones
- Submit
- Digest
- Export
- View Statistics
- Search

Show feedback again

patch #3560: Use standard button interface (patch 21/60)

Submitted by:	Marko Lindqvist <cazfi>
Submitted on:	Tue 13 Nov 2012 11:44:59 PM UTC

Category:	client-gtk-3.0	Priority:	5 - Normal
Status:	None	Privacy:	Public
Assigned to:	None	Open/Closed:	Open
Planned Release:	2.5.0

Add a New Comment (Rich Markup):

You are not logged in

Please log in, so followups can be emailed to you.

( Jump to the original submission)

Sat 04 May 2013 08:08:59 AM UTC, comment #6: It's not about whether one can understand what the button says, but about always noticing it, subconsciously at least. With just the button text one may quickly changes the other settings without looking if this "master switch" actually makes the (correct) changes to take effect.	Marko Lindqvist <cazfi>
Fri 03 May 2013 06:09:14 PM UTC, comment #5: As with any other gtk-setting, gtk-button-images can be set in settings.ini accompanying gtk.css. Though I stand by what I wrote in patch #3889 (and a few other places) on this topic.	Rafał Mużyło <galtgendo>
Wed 01 May 2013 06:18:35 PM UTC, comment #4: > Well, we could just set this to true in the theme. Sorry, I had (probably) misinterpreted this earlier. You mean it's just change in Freeciv theme to make the image visible again?	Marko Lindqvist <cazfi>
Sat 17 Nov 2012 02:49:37 AM UTC, comment #3: Well, we could just set this to true in the theme. Note, that there are other places already affected by this setting - that screenshot in patch #3561 suggests you didn't notice that.	Rafał Mużyło <galtgendo>
Fri 16 Nov 2012 11:34:40 PM UTC, comment #2: > As it's a standard button now, it follows the theme. Uhm. Maybe the whole point of not having it as standard button earlier was that it's better with glaring indicator of governor state. With this patch it has just the text. Can you list some pros (and cons) for this patch?	Marko Lindqvist <cazfi>
Wed 14 Nov 2012 02:07:41 AM UTC, comment #1: Actually, that probably means it does work. The answer may lie in "gtk-button-images" from GtkSettings. As it's a standard button now, it follows the theme.	Rafał Mużyło <galtgendo>
Tue 13 Nov 2012 11:44:59 PM UTC, original submission: This ticket is about handling patch 21/60 (Use standard button interface) from Rafał Mużyło's patchset in patch #3469 I tested this patch, and it seems that the red/green icon from the golvernor on/off button disappears with the patch.	Marko Lindqvist <cazfi>

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):


Comment:

No files currently attached

Depends on the following items: None found

Items that depend on this one: None found

Carbon-Copy List

-unavailable- added by cazfi (Submitted the item)

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

Please enter the title of George Orwell's famous dystopian book (it's a date):

No Changes Have Been Made to This Item

Show feedback again