patchFreeciv - Patches: patch #3566, Use grids for worklists (patch...

 
 
Show feedback again

patch #3566: Use grids for worklists (patch 31/60)

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Sat 17 Nov 2012 12:40:52 AM UTC  
 
Category: client-gtk-3.0Priority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.4.0,2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sat 23 Mar 2013 10:35:41 AM UTC, SVN revision 22568:

Use GtkGrid for worklists.

Patch by Rafa?\197?\130 Mu?\197?\188y?\197?\130o

See gna patch #3566

(Browse SVN revision 22568)

Jacob Nevins <jtn>
Project Administrator
Thu 22 Nov 2012 01:20:00 AM UTC, SVN revision 22025:

Use GtkGrid in for worklists.

Patch by Rafa?\197?\130 Mu?\197?\188y?\197?\130o

See gna patch #3566

(Browse SVN revision 22025)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu 22 Nov 2012 01:18:37 AM UTC, comment #4:

Bug is now bug #20319

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 17 Nov 2012 04:33:28 AM UTC, comment #3:

I reproduced something similar (but without the assertion) without the patch, so it's not new with the patch.

It seems that "Change Production" does not work after you have already done one "thing" with the worklist. You can "Change Production" once succesfully, if you do nothing else before.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 17 Nov 2012 04:24:15 AM UTC, comment #2:

> Are you sure this patch plays a role here?


Well, as you found out that it's not happening reliably, it probably was coincidence. It didn't happen before I applied the patch, it happened with the patch, and again didn't happen once I reverted the patch.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 17 Nov 2012 02:29:04 AM UTC, comment #1:

Are you sure this patch plays a role here ? It shouldn't affect anything but packing (and nothing in its content suggests it could).

While at the first I seem to have reproduced the problem, I've noticed a warning in the terminal:
(freeciv-gtk3:4695): Gtk-CRITICAL **: gtk_tree_model_get_iter: assertion `GTK_IS_TREE_MODEL (tree_model)' failed

I've restarted the client and this time I couldn't reproduce it...or at least I don't think I did.

Anyway, this doesn't seem to be a problem with grids, but one somewhere along GtkListStore/GtkTreeView line.

Though I'm not rejecting the possibility the problem lies within gtk itself.

Rafał Mużyło <galtgendo>
Sat 17 Nov 2012 12:40:52 AM UTC, original submission:

This ticket is about handling patch 31/60 (Use grids for worklists) from Rafał Mużyło's patchset in patch #3469

1. Put several items to city worklist
2. Select from the Source Tasks something that is not what city is currently producing
3. Click "Change Production"
4. Notice how first item in worklist (=current production) does not change as it should. Bug is just in that new production is not shown there, it does change in reality, and is shown in ohter places

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jtn (Updated the item)
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 23 Mar 2013 10:39:09 AM UTCjtnPlanned Release2.5.0=>2.4.0,2.5.0
    Thu 22 Nov 2012 01:20:23 AM UTCcazfiStatusReady For Test=>Done
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Sat 17 Nov 2012 10:35:31 AM UTCcazfiCategoryNone=>client-gtk-3.0
      StatusNone=>Ready For Test
      Planned Release=>2.5.0
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup