Freeciv - Patches: patch #3572, Use grids for voteinfo

Freeciv - Patches: patch #3572, Use grids for voteinfo_bar

Group

Main
- Main
- View Members
- Search
Homepage
Download
Docs
- Browse
- Submit
- Edit
- Digest
- Export
- Search
Mailing Lists
Source Code
- Use Subversion
- Browse Sources Repository
Bugs
- Browse
- Reset to all open ones
- Submit
- Digest
- Export
- View Statistics
- Search
Tasks
- Browse
- Reset to all open ones
- Submit
- Digest
- Export
- View Statistics
- Search
Patches
- Browse
- Reset to all open ones
- Submit
- Digest
- Export
- View Statistics
- Search

Show feedback again

patch #3572: Use grids for voteinfo_bar

Submitted by:	Marko Lindqvist <cazfi>
Submitted on:	Tue 11 Dec 2012 10:42:01 AM UTC

Category:	client-gtk-3.0	Priority:	5 - Normal
Status:	Done	Privacy:	Public
Assigned to:	Marko Lindqvist <cazfi>	Open/Closed:	Closed
Planned Release:	2.4.0, 2.5.0

Add a New Comment (Rich Markup):

You are not logged in

Please log in, so followups can be emailed to you.

( Jump to the original submission)

Wed 03 Apr 2013 07:42:52 PM UTC, SVN revision 22661: Use GtkGrid in vote bar. Patch by Rafa?\197?\130 Mu?\197?\188y?\197?\130o See patch #3572 (Browse SVN revision 22661)	Marko Lindqvist <cazfi>
Wed 03 Apr 2013 07:42:45 PM UTC, SVN revision 22660: Use GtkGrid in vote bar. Patch by Rafa?\197?\130 Mu?\197?\188y?\197?\130o See patch #3572 (Browse SVN revision 22660)	Marko Lindqvist <cazfi>
Sun 31 Mar 2013 10:17:24 PM UTC, comment #5: Now tested by jtn's instructions.	Marko Lindqvist <cazfi>
Sat 16 Mar 2013 01:58:14 PM UTC, comment #4: > Am I right in thinking that the only blocker to applying this > patch is that no-one's sanity-checked the resulting behaviour of > voting in the client? Yes	Marko Lindqvist <cazfi>
Sat 16 Mar 2013 01:34:22 PM UTC, comment #3: Am I right in thinking that the only blocker to applying this patch is that no-one's sanity-checked the resulting behaviour of voting in the client?	Jacob Nevins <jtn>
Thu 28 Feb 2013 12:06:02 AM UTC, comment #2: You can test voting by: Starting a separate server Connecting several clients (I usually use 3) After they've all connected (cf bug #20556), issue "/cmdlevel basic" on the server Try to change some suitable setting, such as "size" (either from chatline or GUI) Then all the clients should have the vote bar come up with a message like "Vote 1 by pamcakes: set size 5 (needs 51% in favor)", with YES/NO/ABSTAIN buttons.	Jacob Nevins <jtn>
Tue 11 Dec 2012 05:39:12 PM UTC, comment #1: Actually, I couldn't really test it either - didn't really know how to force displaying that bar for longer than a moment it appears during a single player game. I don't see anything that would be obviously wrong with it though. However, (unrelated to the patch itself) the spaces in widgets' names might make it impossible to address them via css.	Rafał Mużyło <galtgendo>
Tue 11 Dec 2012 10:42:01 AM UTC, original submission: this ticket is about handling patch 53/60 (use grids for voteinfo_bar) from Rafał Mużyło's patchset in patch #3469 This patch is not postponed because of any known problem, but I'm yet to build setup where I can test it.	Marko Lindqvist <cazfi>

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):


Comment:

No files currently attached

Depends on the following items: None found

Items that depend on this one: None found

Carbon-Copy List

-unavailable- added by jtn (Posted a comment)

-unavailable- added by cazfi (Submitted the item)

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

Please enter the title of George Orwell's famous dystopian book (it's a date):

Follow 4 latest changes.

Date	Changed By	Updated Field	Previous Value	Replaced By
Wed 03 Apr 2013 07:46:02 PM UTC	cazfi	Status	Ready For Test	Done
		Open/Closed	Open	Closed
Sun 31 Mar 2013 10:17:24 PM UTC	cazfi	Assigned to	None	cazfi
		Planned Release	2.5.0	2.4.0, 2.5.0

Show feedback again