patchFreeciv - Patches: patch #3574, Fixed SVG nation flag files

 
 
Show feedback again

patch #3574: Fixed SVG nation flag files

Submitted by:  Davide Baldini <davide_at_debian>
Submitted on:  Thu 13 Dec 2012 02:19:20 AM UTC  
 
Category: generalPriority: 3 - Low
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.3.4, 2.4.0, 2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Thu 17 Jan 2013 11:24:40 PM UTC, comment #7:

No, as the lines 7, 8 of the patch (attached file #16842) show:

Davide Baldini <davide_at_debian>
Thu 17 Jan 2013 10:43:59 PM UTC, comment #6:

> I would have to edit and test on browser every single image
> manually, so it'd be a tedious and long task.


You don't think simple
grep -L "xmlns" *.svg
would suffice?

Applied S2_3 version to all branches anyway.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu 17 Jan 2013 10:39:16 PM UTC, SVN revision 22142:

Added SVG namespace to some flag files missing it.

Patch by Davide Baldini

See gna patch #3574

(Browse SVN revision 22142)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu 17 Jan 2013 10:39:11 PM UTC, SVN revision 22141:

Added SVG namespace to some flag files missing it.

Patch by Davide Baldini

See gna patch #3574

(Browse SVN revision 22141)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu 17 Jan 2013 10:39:04 PM UTC, SVN revision 22140:

Added SVG namespace to some flag files missing it.

Patch by Davide Baldini

See gna patch #3574

(Browse SVN revision 22140)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu 20 Dec 2012 02:01:12 AM UTC, comment #2:

Patch smoothly applies to both trunk and S2_4.
This patch "fixes" all the flags for 2.3.2; as of now, I'm not checking for other flags (2.4 and trunk) as I would have to edit and test on browser every single image manually, so it'd be a tedious and long task.

Davide Baldini <davide_at_debian>
Sat 15 Dec 2012 11:09:49 PM UTC, comment #1:

Freeciv does not use (not even freeciv-web) svg files directly, but only pngs generated from them, but of course proper format would be prefered.

Can you check newer branches (S2_4 and TRUNK) if your patch apply there, and if all the new flags there are ok?

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu 13 Dec 2012 02:19:20 AM UTC, original submission:

Some of the SVG flag files contained in ./data/flags/ miss a proper "SVG namespace". This is causing no harm to Freeciv itself, but a namespace declaration in SVG images increases the compatibility of these files toward other applications beyond of Freeciv.

In particular, I'm currently working on a web-centered variation of Freeciv, similar to Longturn, and I've seen that such SVGs are not properly rendered by the most common browsers; adding the required namespace to the files makes the images work.
This fix doesn't affect any functionality of Freeciv.

Patch tested on 2.3.2 and 2.3.3.

Davide Baldini <davide_at_debian>

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by davide_at_debian (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 17 Jan 2013 10:43:59 PM UTCcazfiStatusNone=>Done
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
      Planned Release=>2.3.4, 2.4.0, 2.5.0
    Thu 13 Dec 2012 02:19:20 AM UTCdavide_at_debianAttached File-=>Added svg_flags_fix-2.3.2.diff, #16842
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup