patchFreeciv - Patches: patch #3606, Configure check for intptr_t

 
 
Show feedback again

patch #3606: Configure check for intptr_t

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Sun 20 Jan 2013 01:29:55 PM UTC  
 
Category: bootstrapPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.4.0, 2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 23 Jan 2013 10:01:01 PM UTC, SVN revision 22195:

Added configure check for defining intptr_t.

See gna patch #3606

(Browse SVN revision 22195)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 23 Jan 2013 10:00:49 PM UTC, SVN revision 22194:

Added configure check for defining intptr_t.

See gna patch #3606

(Browse SVN revision 22194)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Tue 22 Jan 2013 05:28:22 PM UTC, comment #3:

- In case of autoconf-2.59, check if inttypes.h provides intptr_t, and define it ourselves only if it doesn't

(file #16990)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Tue 22 Jan 2013 09:32:15 AM UTC, comment #2:

I have not tested, but I now realized that this is probably horribly broken with autoconf-2.59 case.

I already wrote commit message like this before I decided not to commit yet:
"Added configure check for defining intptr_t.
Support for this was introduced in autoconf-2.60. In case
of autoconf-2.59 we fallback to using "unsigned long" we have
been using where intptr_t should be used, i.e., we won't
support LLP64 systems, such as win64, in combination with
autoconf-2.59."

Problem is that unconditionally defining intptr_t in autoconf-2.59 case ignores the fact that it's likely defined in system headers anyway, maybe as typedef. So, after our unconditional macro expansion system header will turn from
typedef intptr_t unsigned long
to
typedef unsigned long unsigned long

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 20 Jan 2013 04:23:58 PM UTC, comment #1:

Actually, this one is (relatively) safe to commit to S2_4 already. It just provides some support for bug #20392 to come later.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 20 Jan 2013 01:29:55 PM UTC, original submission:

Add configure check for intptr_t.

This is another part of configure.ac that would be cleaner if we bumped minimum autoconf version to just 2.60 (from current 2.59). I didn't do it yet in this patch, as this later needs to go to S2_4 too (probably merged to S2_4 version of bug #20392).

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #16990:  IntPtrConfigure-2.patch added by cazfi (600B - text/x-diff)
file #16981:  IntPtrConfigure.patch added by cazfi (507B - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 23 Jan 2013 10:01:34 PM UTCcazfiStatusReady For Test=>Done
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Tue 22 Jan 2013 05:28:22 PM UTCcazfiAttached File-=>Added IntPtrConfigure-2.patch, #16990
    Sun 20 Jan 2013 04:23:58 PM UTCcazfiPlanned Release2.5.0=>2.4.0, 2.5.0
    Sun 20 Jan 2013 01:29:55 PM UTCcazfiAttached File-=>Added IntPtrConfigure.patch, #16981
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup