patchFreeciv - Patches: patch #3611, Ruleset setting about cancelling...

 
 
Show feedback again

patch #3611: Ruleset setting about cancelling illegal traderoutes

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Tue Jan 22 21:03:11 2013  
 
Category: generalPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.5.0Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon Jan 28 15:48:29 2013, SVN revision 22228:

Added ruleset setting to control what happens to existing traderoutes
which are no longer legal. This can happen when traderoute type changes
as a result of city changing owner or terrain transformations.

See gna patch #3611

(Browse SVN revision 22228)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu Jan 24 20:37:39 2013, comment #1:

- Fixed keeping of traderoute over city owner change
- Get 0 trade from Inactive traderoute instead of "random" (uninitialized) amount
- Set values in ruleset "Cancel" rather than "Active" as it turned out that the old behavior was like that when city changes owner and traderoute turns illegal

(file #17009)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Tue Jan 22 21:03:11 2013, original submission:

So far only compile-tested patch, but posting already for discussion.

There's currently no handling of already established traderoutes turned illegal. With most supplied rulesets such a thing could happen if city changes owner and suddenly trading cities should be at least trademindist apart, but are not. Civ2civ3 ruleset prohibits national traderoutes altogether.
Does anybody know how civ/2 handle this? In attached patch I've added only TOOD comment to civ/2 rulesets that settings should be corrected.

Patch adds ruleset setting to control what happens to each kind (national, intercontinental, international, inic) of illegal traderoutes. Possible values are "Active" - traderoute is fully functional, "Inactive" - traderoute is not functional, but remains in case it later turns back legal, and "Cancel" - traderoute is removed.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Error: not logged in

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon Jan 28 15:48:41 2013cazfiStatusReady For Test=>Done
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Thu Jan 24 20:37:39 2013cazfiAttached File-=>Added TraderouteCancellingSetting-2.patch, #17009
    Tue Jan 22 21:03:11 2013cazfiAttached File-=>Added TraderouteCancellingSetting.patch, #16992
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup