patchFreeciv - Patches: patch #3613, Killcitizen not move_type dependant

 
 
Show feedback again

patch #3613: Killcitizen not move_type dependant

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Wed Jan 23 14:11:49 2013  
 
Category: generalPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.5.0Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun Jan 27 22:58:16 2013, SVN revision 22221:

Made killcitizen setting boolean instead of enum of move_types.
New unit class flag "KillCitizen" in ruleset determines which units
do kill citizens if setting is enabled. For all of the supplied
rulesets this flag is given to unit classes so that there's no
gameplay change if default rules are being used.

See gna patch #3613

(Browse SVN revision 22221)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri Jan 25 10:53:13 2013, comment #1:

- Updated against current svn head

(file #17020)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed Jan 23 14:11:49 2013, original submission:

Killcitizen is one of the remaining places for which unit move_type is needed outside ai code.

Attached patch makes killcitizen setting boolean instead of list of move_types. New unit class flag "KillCitizen" in ruleset determines which units do kill citizens if setting is enabled. For all of the supplied rulesets this flag is given to unit classes so that there's no gameplay change if default rules are being used (land moving units have the flag)

It would make sense to make some adjustments to alien ruleset in future tickets taking advantage of the new ruleset power of determining killcitizen units (Amphibious units at least could kill, Burrowing on the other hand might not)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Error: not logged in

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun Jan 27 22:58:43 2013cazfiStatusReady For Test=>Done
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Fri Jan 25 10:53:13 2013cazfiAttached File-=>Added KillCitizenNotMoveType-2.patch, #17020
    Wed Jan 23 14:11:49 2013cazfiAttached File-=>Added KillCitizeinNotMoveType.patch, #17002
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup