patchFreeciv - Patches: patch #3614, Minimum native start area

 
 
Show feedback again

patch #3614: Minimum native start area

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Wed Jan 23 21:46:47 2013  
 
Category: generalPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.5.0Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun Jan 27 11:52:06 2013, comment #4:

> Perhaps it will become necessary in some circumstances for the
> map generator to actively ensure that such contiguous native
> areas exist? I assume you tested it with 'alien' and there are
> usually enough such areas generated naturally currently.


In fact I've found out that it's better to fail map generation in such cases. It was very frustrating to enter the alien ruleset game and to play a few turns just to find out that starting situation is unplayable, sometimes several attempts in a row. And that's only your own starting position - it may take very long time to find out that you don't have any AI to play against as your enemy is locked to one tile area. I much prefer it to retry map generation automatically, and failing even that to abort. Not that I've encountered such a situation during testing - there's usually contiguous areas, old code just happened to pick bad places instead.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun Jan 27 11:41:25 2013, comment #3:

Some (late, not critical) thoughts on seeing this:

  • Would it be worth being able to pass in min_start_native_area to count_native_area(), so that it can bail out early when the minimum is reached? Otherwise, it's going to iterate over entire continents every time it evaluates a start position, I'd have thought. (I realise the check is disabled for traditional rulesets.)
  • Perhaps it will become necessary in some circumstances for the map generator to actively ensure that such contiguous native areas exist? I assume you tested it with 'alien' and there are usually enough such areas generated naturally currently.
Jacob Nevins <jtn>
Project Administrator
Sun Jan 27 11:08:54 2013, SVN revision 22213:

Added terrain.ruleset setting for minimum native area reachable by
initial startunit. Setting is 0 (not used) for all the rulesets except
for alien where it is 15.

See gna patch #3614

(Browse SVN revision 22213)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu Jan 24 23:41:05 2013, comment #1:

- Use dbv instead of bool array.

(file #17013)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed Jan 23 21:46:47 2013, original submission:

Add terrain.ruleset setting for minimum native area reachable by initial startunit. Setting is 0 (not used) for all the rulesets except for alien where it is 15. For other rulesets always present checks for island size work better, but in alien ruleset initial units are limited to certain land terrains only. Until this patch player has occasionally started alien ruleset with unplayable small reachable area, including extreme cases of just the one tile where initial units stand.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #17013:  MinNativeArea-2.patch added by cazfi (8kB - text/x-diff)
file #17004:  MinNativeArea.patch added by cazfi (8kB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jtn (Posted a comment)
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Error: not logged in

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun Jan 27 11:09:06 2013cazfiStatusReady For Test=>Done
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Thu Jan 24 23:41:05 2013cazfiAttached File-=>Added MinNativeArea-2.patch, #17013
    Wed Jan 23 21:46:47 2013cazfiAttached File-=>Added MinNativeArea.patch, #17004
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup