patchFreeciv - Patches: patch #3675, Rivers as road types in rulesets

 
 
Show feedback again

patch #3675: Rivers as road types in rulesets

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Thu Feb 7 03:55:39 2013  
 
Category: rulesetsPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.5.0Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Mon Mar 18 20:54:39 2013, SVN revision 22528:

Implemented river as road type in all supplied rulesets.

See patch #3675

(Browse SVN revision 22528)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat Mar 9 07:58:49 2013, comment #6:

- Set "buildable" and "pillageable" with proper boolean value (as required by current ruleset format)

(file #17411)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed Feb 27 21:43:41 2013, comment #5:

- Added flag "Natural" for all rivers
- Made trade increases to be terrain-independent
- Removed flag "PreventsOtherRoads" flag from alien ruleset river as there road building is always possible on river tiles too
- Removed a lot of fields with default value 0 from river definitions in most rulesets. Classic ruleset which is often used as referense has all the fields visible.

(file #17370)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun Feb 24 09:20:55 2013, comment #4:

- Updated to apply against svn HEAD

(file #17328)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat Feb 16 03:36:58 2013, comment #3:

- Made rivers unpillageable
- Changed river requirement types in all lists "Special" -> "Road"
- Replaced "GeneratedRiver" flag with "River" to apply on top of patch #3695

(file #17213)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun Feb 10 11:06:15 2013, comment #2:

> Setting the rivers to non pillageable was forgotten.


Thansk for catching this. Another bug is that in all the requirements lists requirement "Special"/"River" should be replaced with "Road"/"River". This affects irrigation at least.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun Feb 10 05:15:38 2013, comment #1:

Had a look. Setting the rivers to non pillageable was forgotten.

PS! Thanks for publishing this patch and therefore making it less time consuming to try river as road before it's done

Sveinung Kvilhaugsvik <sveinung>
Project Member
Thu Feb 7 03:55:39 2013, original submission:

Add River as road type to all our rulesets.

I've tried to carefully make the road type rivers similar to what river specials in each ruleset are, but errors are certainly possible.

I noticed that the only function of rivers in the civ1 ruleset is to prevent building a road before Bridge Building has been invented. Is that really correct? I don't think civ1 had exactly same output for Rivers and normal Grassland tiles.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #17411:  RiverRulesetRoads-5.patch added by cazfi (15kB - text/x-diff)
file #17370:  RiverRulesetRoads-4.patch added by cazfi (15kB - text/x-diff)
file #17328:  RiverRulesetRoads-3.patch added by cazfi (16kB - text/x-diff)
file #17213:  RiverRulesetRoads-2.patch added by cazfi (16kB - text/x-diff)
file #17152:  RiverRulesetRoads.patch added by cazfi (11kB - text/x-diff)

 

Digest:
   bug dependencies.

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by sveinung (Posted a comment)
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Error: not logged in

     

     

    Follow 10 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon Mar 18 20:54:53 2013cazfiStatusReady For Test=>Done
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Wed Mar 13 17:26:25 2013cazfiDependencies-=>Depends on bugs #20614
    Sat Mar 9 07:58:49 2013cazfiAttached File-=>Added RiverRulesetRoads-5.patch, #17411
    Wed Feb 27 21:43:41 2013cazfiAttached File-=>Added RiverRulesetRoads-4.patch, #17370
    Sun Feb 24 09:20:55 2013cazfiAttached File-=>Added RiverRulesetRoads-3.patch, #17328
      StatusIn Progress=>Ready For Test
    Sat Feb 16 03:36:58 2013cazfiAttached File-=>Added RiverRulesetRoads-2.patch, #17213
    Thu Feb 7 03:55:39 2013cazfiAttached File-=>Added RiverRulesetRoads.patch, #17152
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup