apply unit animation WML patch #3682 and return deleted Steelclad-idle images as OKd by Jetrel.

(Browse SVN revision 56479)

I've attached the WML patch which addresses the souless drake death frame count by adding the count to the macro specification (and doing the same for the WC).

There are also updates to the syntax for the newly comitted dwarf fighter line since they came along recently as well as this patch. However, they will need the steelclad-idle#.png series of images put back for it to fully work, as they look to have been taken out and I couldn't include them in the patch.

(file #17278)

Updated the Wiki.

I've included another minor patch to fix some errors that crept in when updating the syntax of some units and update another begin/end depreciated set of tags.

The only problem I see now is the soulless drake variation death animation. Although this would have been a problem before updating the syntax, it needs another frame of death animation or we could change the death macro to specify the number of frames (made possible by the new syntax).

(file #17224)

I think you are right about the does_not_change function. I put an entry in for image and image_diagonal in the appropriate places and it now loops properly :)

This latest patch is split into the cpp code and the unit WML changes (all units have been converted).

In all, with these optimizations 9% less RAM is taken by Wesnoth by my tests from without these changes applied and can only be a good thing for loading speed when more standing/idle/etc. andimations come in.

I fixed a bug with the necrophage (attack frame 3 was never used) and similar fixes were applied throughout. Chances are that I introduced one or two bugs myself, like the thief one (now fixed). This is why I am saying that this is a v1 patch, but should be "complete" in the sense that it is intended to work fully.

(file #17210, file #17211)

This is intended to be the last major application of the square_parenthetical_split function to unit animation WML.
*see http://forums.wesnoth.org/viewtopic.php?f=10&t=38198

The attached patch is a work in progress, converting fully only the human units to the new syntax and the animation macros (running/etc.). At the moment the idle animations do not work, and I suspect this is because they have mainly one frame block now and will need that 'cycle' parameter to be implemented that is on the supposedly 'easy_to_code' page. The fencer is a good example here.

Everything else seems to work.

I have been converting all the 'begin' and 'end' tags over to the new syntax as I've been going along, as these were set to be depreciated anyway.

Lastly, I picked up on some errors that were present in the original animations. FAERIE FIRE had an in-between halo sequence that was never played in game, due to the duration being too short for it. The arch mage idle animation showed the male unit due to missing frames for the female section, and the drake fire breath macro had a halo that had an incorrect duration (although still worked). Hopefully this new syntax will be less prone to errors like these.