patchFreeciv - Patches: patch #3685, dio_get_xxx() returned value

 
 
Show feedback again

patch #3685: dio_get_xxx() returned value

Submitted by:  pepeto <pepeto>
Submitted on:  Sun 10 Feb 2013 12:24:16 PM UTC  
 
Category: generalPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: pepeto <pepeto>Open/Closed: Closed
Planned Release: 2.4.0, 2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 15 Feb 2013 01:15:48 PM UTC, SVN revision 22338:

Make the dio_get_xxx() functions returning TRUE only if the data was correctly
handled.

See gna patch #3685

(Browse SVN revision 22338)

pepeto <pepeto>
Project MemberIn charge of this item.
Fri 15 Feb 2013 01:15:45 PM UTC, SVN revision 22337:

Make the dio_get_xxx() functions returning TRUE only if the data was correctly
handled.

See gna patch #3685

(Browse SVN revision 22337)

pepeto <pepeto>
Project MemberIn charge of this item.
Sun 10 Feb 2013 12:24:16 PM UTC, original submission:

From bug #20003:

>> IIRC return value is solely about whether data was available
>> (and read). These low-level functions do not know what data is
>> valid. Maybe dio_get_uint8() has a bug?
>
> I think so. I will try to investigate a bit deeper...


dio_get_uint8() may be wrong when 'dest' argument is NULL. After having checked everywhere this function is called in the current code, it never should be problematic.

So, the attached patch shouldn't fix anything, except that the returned value is always what it is supposed to be.

I attach a version for S2_4 too.

pepeto <pepeto>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #17171:  trunk_dio_get_xxx.diff added by pepeto (18kB - text/x-diff)
file #17172:  S2_4_dio_get_xxx.diff added by pepeto (18kB - text/x-diff)

 

Depends on the following items: None found

Digest:
   patch dependencies.

 

Carbon-Copy List
  • -unavailable- added by pepeto (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 15 Feb 2013 01:16:21 PM UTCpepetoStatusReady For Test=>Done
      Open/ClosedOpen=>Closed
      Planned Release=>2.4.0, 2.5.0
    Wed 13 Feb 2013 05:11:04 PM UTCpepetoAssigned toNone=>pepeto
    Sun 10 Feb 2013 12:50:14 PM UTCpepetoDependencies-=>patch #3688 is dependent
    Sun 10 Feb 2013 12:27:22 PM UTCpepetoDependencies-=>patch #3686 is dependent
    Sun 10 Feb 2013 12:24:16 PM UTCpepetoAttached File-=>Added trunk_dio_get_xxx.diff, #17171
      Attached File-=>Added S2_4_dio_get_xxx.diff, #17172
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup