patchFreeciv - Patches: patch #3687, Ensure all packets fields have...

Show feedback again

patch #3687: Ensure all packets fields have been correctly read

Submitted by:  pepeto <pepeto>
Submitted on:  Sun 10 Feb 2013 12:31:54 PM UTC  
Category: generalPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: pepeto <pepeto>Open/Closed: Closed
Planned Release: 2.5.0

Add a New Comment (Rich MarkupRich Markup):

You are not logged in

Please log in, so followups can be emailed to you.


Fri 15 Feb 2013 01:36:12 PM UTC, SVN revision 22340:

Ensure all packets fields have been correctly read before accepting to handle
it. Else, break the connection.

Remove obsolete comments about network protocol and packet handling.

See gna patch #3687

(Browse SVN revision 22340)

pepeto <pepeto>
Project MemberIn charge of this item.
Sun 10 Feb 2013 12:35:26 PM UTC, comment #1:

I forgot to say that this patch also remove some obsolete comments about the network protocol.

pepeto <pepeto>
Project MemberIn charge of this item.
Sun 10 Feb 2013 12:31:54 PM UTC, original submission:

Currently, if the server or the client fails to read some fields on a packet, it restore former values or set them to zero. The packet can be very different of what the other instance wanted to send. Actually this should never happen as long as the packets are encoded by the dio_put_xxx() functions and the capability string handle correctly the variants.

This patch break the connections when fields are missing or incorrectly encoded.

pepeto <pepeto>
Project MemberIn charge of this item.


(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):

Attached Files
file #17174:  packet_full_checking.diff added by pepeto (24kB - text/x-diff)


Depends on the following items

   patch dependencies.

Items that depend on this one: None found


Carbon-Copy List
  • -unavailable- added by pepeto (Submitted the item)

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.


    Please enter the title of George Orwell's famous dystopian book (it's a date):



    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 15 Feb 2013 01:36:24 PM UTCpepetoStatusReady For Test=>Done
    Wed 13 Feb 2013 05:11:53 PM UTCpepetoAssigned toNone=>pepeto
      Planned Release=>2.5.0
    Sun 10 Feb 2013 12:32:24 PM UTCpepetoDependencies-=>Depends on patch #3686
    Sun 10 Feb 2013 12:31:54 PM UTCpepetoAttached File-=>Added packet_full_checking.diff, #17174
    Show feedback again

    Back to the top

    Powered by Savane 3.1-cleanup