patchFreeciv - Patches: patch #3688, dio_put_xxx() cleanup

Show feedback again

patch #3688: dio_put_xxx() cleanup

Submitted by:  pepeto <pepeto>
Submitted on:  Sun 10 Feb 2013 12:44:46 PM UTC  
Category: generalPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: pepeto <pepeto>Open/Closed: Closed
Planned Release: 2.5.0Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):

You are not logged in

Please log in, so followups can be emailed to you.


Fri 15 Feb 2013 01:47:57 PM UTC, SVN revision 22341:

Add error messages on data_out overflow.
Don't assume that 'sizeof(int) == 4'.
Set positive values to simulate a NULL pointer id in packets.

See gna patch #3688

(Browse SVN revision 22341)

pepeto <pepeto>
Project MemberIn charge of this item.
Sun 10 Feb 2013 12:44:46 PM UTC, original submission:

This patch :

  • adds error messages when fields inserted in the struct data_out cannot be correctly set.
  • doesn't assume anymore that sizeof(int) == 4 when converting signed and unsigned values.
  • set correct values in packets before being sending (using most of the time the xxx_count() wrappers).
pepeto <pepeto>
Project MemberIn charge of this item.


(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):

Attached Files
file #17175:  dio_put_xxx.diff added by pepeto (12kB - text/x-diff)


   bug dependencies, patch dependencies.

Items that depend on this one

   patch dependencies.


Carbon-Copy List
  • -unavailable- added by pepeto (Submitted the item)

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.


    Error: not logged in



    Follow 10 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 15 Feb 2013 01:48:09 PM UTCpepetoStatusReady For Test=>Done
    Wed 13 Feb 2013 05:12:07 PM UTCpepetoAssigned toNone=>pepeto
      Planned Release=>2.5.0
    Sun 10 Feb 2013 03:24:10 PM UTCpepetoDependencies-=>patch #3690 is dependent
    Sun 10 Feb 2013 03:20:14 PM UTCpepetoDependencies-=>Depends on bugs #20494
    Sun 10 Feb 2013 12:50:14 PM UTCpepetoDependencies-=>Depends on patch #3685
    Sun 10 Feb 2013 12:48:48 PM UTCpepetoDependencies-=>Depends on bugs #20492
    Sun 10 Feb 2013 12:48:10 PM UTCpepetoDependencies-=>Depends on bugs #20493
    Sun 10 Feb 2013 12:44:46 PM UTCpepetoAttached File-=>Added dio_put_xxx.diff, #17175
    Show feedback again

    Back to the top

    Powered by Savane 3.1-cleanup