patchFreeciv - Patches: patch #3691, Handle lookup_req_list errors

 
 
Show feedback again

patch #3691: Handle lookup_req_list errors

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Mon 11 Feb 2013 12:31:45 AM UTC  
 
Category: generalPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.4.0, 2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 15 Feb 2013 05:55:13 AM UTC, SVN revision 22333:

Make errors in requirement list lookups hard errors instead of just
leaving out broken requirements,

See gna patch #3691

(Browse SVN revision 22333)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri 15 Feb 2013 05:54:24 AM UTC, SVN revision 22332:

Return error from ruleset loading for errors in requirement list lookups
instead of just leaving out broken requirements,

See gna patch #3691

(Browse SVN revision 22332)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 11 Feb 2013 12:31:45 AM UTC, original submission:

Handle all errors in lookup_req_list() gracefully.

S2_4 goes the opposite direction. There is no way to handle errors gracefully, but ignoring the errors as the old code does is not good either. It was just ignoring illegal requirements. It's better to make errors known to ruleset author by aborting upon them than silently running with broken ruleset (missing requirement that author meant to be there, maybe simply because typo in name).

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #17181:  HandleLookupReqListErrors.patch.bz2 added by cazfi (6kB - application/x-bzip)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 15 Feb 2013 05:55:30 AM UTCcazfiStatusReady For Test=>Done
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Mon 11 Feb 2013 12:31:45 AM UTCcazfiAttached File-=>Added HandleLookupReqListErrors.patch.bz2, #17181
      Attached File-=>Added FatalReqListErrors-S2_4.patch, #17182
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup