patchFreeciv - Patches: patch #3706, Use TRUE and FALSE instead of 1...

 
 
Show feedback again

patch #3706: Use TRUE and FALSE instead of 1 and 0 in rulesets

Submitted by:  pepeto <pepeto>
Submitted on:  Sat 16 Feb 2013 11:23:06 PM UTC  
 
Category: rulesetsPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: pepeto <pepeto>Open/Closed: Closed
Planned Release: 2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 19 Feb 2013 11:06:38 AM UTC, comment #4:

> I haven't been following closely. Did this require some
> code-side change first? That is; does wiki ruleset
> documentation need to document that this is new behavior in
> 2.5? Latest freeciv release is 2.3, so documentation in wiki
> should be usable for 2.3 and 2.4 at least.


'TRUE' and 'FALSE' are compatible with 2.3, so what I edited in the "Editing rulesets" matches the current version.

I added a section about transforming old '0' and '1' only in "How to update a ruleset from 2.4 to 2.5".

The code-side change will come very quickly, I just removed one part of my patch today, so I didn't commit it yet (patch #2190).

pepeto <pepeto>
Project MemberIn charge of this item.
Tue 19 Feb 2013 10:48:29 AM UTC, comment #3:

> Documentation updated at wikia.


I haven't been following closely. Did this require some code-side change first? That is; does wiki ruleset documentation need to document that this is new behavior in 2.5? Latest freeciv release is 2.3, so documentation in wiki should be usable for 2.3 and 2.4 at least.

Marko Lindqvist <cazfi>
Project Administrator
Tue 19 Feb 2013 10:39:20 AM UTC, comment #2:

Documentation updated at wikia.

pepeto <pepeto>
Project MemberIn charge of this item.
Tue 19 Feb 2013 09:35:37 AM UTC, SVN revision 22385:

Use 'TRUE' and 'FALSE' instead of '1' and '0' for booleans in rulesets.

See gna patch #3706

(Browse SVN revision 22385)

pepeto <pepeto>
Project MemberIn charge of this item.
Sat 16 Feb 2013 11:23:06 PM UTC, original submission:
pepeto <pepeto>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #17226:  ruleset.diff added by pepeto (49kB - text/x-patch)

 

Depends on the following items: None found

Digest:
   patch dependencies.

 

Carbon-Copy List
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by pepeto (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 19 Feb 2013 10:39:20 AM UTCpepetoStatusReady For Test=>Done
      Open/ClosedOpen=>Closed
    Sat 16 Feb 2013 11:27:08 PM UTCpepetoDependencies-=>patch #2190 is dependent
    Sat 16 Feb 2013 11:23:06 PM UTCpepetoAttached File-=>Added ruleset.diff, #17226
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup