patchFreeciv - Patches: patch #3711, Caravan popups as part of unit...

 
 
Show feedback again

patch #3711: Caravan popups as part of unit focus queue?

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Sun 17 Feb 2013 10:23:00 AM UTC  
 
Category: clientPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Sveinung Kvilhaugsvik <sveinung>Open/Closed: Closed
Planned Release: 3.0.0, 2.6.0Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Thu 10 Mar 2016 01:22:40 PM UTC, comment #12:

> Thank you.

You are welcome.

> Some of that kind of work is done for the Gtk2 client in my prototype for patch #3756;

Feel free to remove and/or modify the "Wait" buttons as a part of that work. (Argument against removing them: They advertise that a unit with an action selection dialog now can wait. Arguments for removing them: More space in the action selection dialog. Consistent "w", not "mnemonics key" + "w")

Sveinung Kvilhaugsvik <sveinung>
Project MemberIn charge of this item.
Thu 10 Mar 2016 01:15:06 PM UTC, SVN revision 32223:

clients: add a Wait button to the act sel dlgs.

Jacob wanted the usual unit focus keys like "W" to dismiss the popup
non-permanently. To do this while the action selection dialog has focus
would probably require a lot of client specific work. Approximate it by
adding a "Wait" button to the action selection dialog. Give it "W" as
mnemonic in clients with mnemonics support.

Note that some clients allows the player to shift focus from the dialog to
the actor unit. In those cases you can use "W" the way it was requested.

Requested by Jacob Nevins

See patch #3711

(Browse SVN revision 32223)

Sveinung Kvilhaugsvik <sveinung>
Project MemberIn charge of this item.
Wed 09 Mar 2016 11:45:07 PM UTC, comment #10:

Thank you.

> Jacob the wanted the usual unit focus keys like "W" to dismiss the popup
> non-permanently. To do this while the action selection dialog has focus
> would probably require a lot of client specific work. [...]

Some of that kind of work is done for the Gtk2 client in my prototype for patch #3756; it redirects keystrokes caught by the action popup to the main window, so that keys like 'W' work. (But is probably not finished.)

Jacob Nevins <jtn>
Project Administrator
Wed 09 Mar 2016 03:24:33 PM UTC, comment #9:

Spelling mistake:

> Jacob the wanted the

Jacob wanted the

> Perhaps you want the option of some unobtrusive proxy for the popup, like a particular modification to the unit icon.

This is now patch #7048

Sveinung Kvilhaugsvik <sveinung>
Project MemberIn charge of this item.
Wed 09 Mar 2016 03:04:43 PM UTC, SVN revision 32212:

clients: add a Wait button to the act sel dlgs.

Jacob the wanted the usual unit focus keys like "W" to dismiss the popup
non-permanently. To do this while the action selection dialog has focus
would probably require a lot of client specific work. Approximate it by
adding a "Wait" button to the action selection dialog. Give it "W" as
mnemonic in clients with mnemonics support.

Note that some clients allows the player to shift focus from the dialog to
the actor unit. In those cases you can use "W" the way it was requested.

Requested by Jacob Nevins

See patch #3711

(Browse SVN revision 32212)

Sveinung Kvilhaugsvik <sveinung>
Project MemberIn charge of this item.
Tue 08 Mar 2016 10:41:02 PM UTC, comment #7:

2.6 version

(file #26962)

Sveinung Kvilhaugsvik <sveinung>
Project MemberIn charge of this item.
Mon 07 Mar 2016 02:39:42 PM UTC, comment #6:

2.6 version not done yet.

(file #26957)

Sveinung Kvilhaugsvik <sveinung>
Project MemberIn charge of this item.
Tue 22 Dec 2015 05:06:29 PM UTC, comment #5:

The server side of patch #6720 can remark a unit when dismissing the action selection dialog pop up non permanently

Sveinung Kvilhaugsvik <sveinung>
Project MemberIn charge of this item.
Fri 27 Nov 2015 09:39:46 AM UTC, SVN revision 30801:

Get rid of separate action selection dialog queue

Get rid of diplomat_arrival_queue by merging it into the unit focus queue.

Requested by Jacob Nevins

(This patch doesn't implement everything asked for in patch #3711)

See patch #6602

(Browse SVN revision 30801)

Sveinung Kvilhaugsvik <sveinung>
Project MemberIn charge of this item.
Thu 19 Nov 2015 09:26:48 AM UTC, SVN revision 30683:

Get rid of separate action selection dialog queue

Get rid of diplomat_arrival_queue by merging it into the unit focus queue.

Requested by Jacob Nevins

(This patch doesn't implement everything asked for in patch #3711)

See patch #6602

(Browse SVN revision 30683)

Sveinung Kvilhaugsvik <sveinung>
Project MemberIn charge of this item.
Tue 19 Feb 2013 04:25:32 AM UTC, comment #2:

About obscuring the action, i wonder if it wouldn't be better if all other unit movements pause until the popup has been dealt with. But, i understand that would come with its own problems.

About forgetting that a caravan is ready, i don't think that's such a big problem. The caravan gets its focus back next turn and essentially just loses a turn. The worst case scenario is if the player forgets sending the caravan there and sends it out again.

David Lowe <doctorjlowe>
Sun 17 Feb 2013 10:33:27 AM UTC, comment #1:

Sounds much better than the minimal fix I've been wanting for the case when player is not logged in during turn change, misses the popups, and never gets them once (s)he logs in.
Currently caravan either automatically creates traderoute (if target was non-allied city) or just goes inside the city (if own or allied city).

Marko Lindqvist <cazfi>
Project Administrator
Sun 17 Feb 2013 10:23:00 AM UTC, original submission:

Following on from discussion in patch #2206:

In general, it does feel like we need a new workflow for caravan orders (and maybe other things like diplomat actions).

Having the popup occur in the flurry of turn-change activities was bad for various reason (e.g. taking focus, obscuring the action), which is why we have "Pop up caravan actions" as an option (r15533), but if you turn that off it's easy to forget that a caravan is ready.

Commercial CivIV has a fairly forced workflow, where it takes you through decisions like city production, promotions, and units in some fixed order. This helps not forget things, but it's still not ideal; if you don't want to deal with a thing at the point it prompts because you need other information (you're locked out of seeing all information due to the forced workflow), you have to cancel and remember to go back and review the thing later.

I wonder if there's scope for putting pending-caravan-decisions on the unit focus queue, and popping up the caravan dialog whenever focus gets to a unit, and allowing the usual unit focus keys like "W" to dismiss the popup non-permanently (so it will appear again next time the unit comes up)? In this world, a unit capable of an action would stay on the queue even if it had no movement points left.

That still doesn't quite fix the case where your first unit after turn change needs a popup, but you don't want the popup obscuring your view of the post-turn action -- although it'll help a bit as the popup will naturally pop up a bit later. Perhaps you want the option of some unobtrusive proxy for the popup, like a particular modification to the unit icon.

(Obviously having the specify-action-in-advance envisaged by bug #16905 would also help some players, but it would still be good to have a better workflow for those not making plans in advance.)

Jacob Nevins <jtn>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

 

Digest:
   bug dependencies, patch dependencies.

Digest:
   patch dependencies.

 

Carbon-Copy List
  • -unavailable- added by sveinung (Updated the item)
  • -unavailable- added by doctorjlowe (Posted a comment)
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Error: not logged in

     

     

    Follow 14 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 10 Mar 2016 01:22:40 PM UTCsveinungStatusReady For Test=>Done
      Open/ClosedOpen=>Closed
    Wed 09 Mar 2016 03:13:17 PM UTCsveinungDependencies-=>patch #7048 is dependent
    Tue 08 Mar 2016 10:41:02 PM UTCsveinungAttached File-=>Added 2.6-clients-add-a-Wait-button-to-the-act-sel-dlgs.patch, #26962
    Mon 07 Mar 2016 02:40:32 PM UTCsveinungStatusIn Progress=>Ready For Test
    Mon 07 Mar 2016 02:39:42 PM UTCsveinungDependencies-=>Depends on bugs #24506
    Mon 07 Mar 2016 02:39:41 PM UTCsveinungAttached File-=>Added 0002-clients-add-a-Wait-button-to-the-act-sel-dlgs.patch, #26957
      StatusIn Progress=>Ready For Test
    Thu 03 Mar 2016 09:33:50 PM UTCsveinungDependencies-=>Depends on patch #7034
    Tue 22 Dec 2015 05:06:29 PM UTCsveinungDependencies-=>Depends on patch #6720
    Tue 17 Nov 2015 12:51:32 PM UTCsveinungDependencies-=>Depends on patch #6602
    Fri 13 Nov 2015 02:08:50 PM UTCsveinungStatusNone=>In Progress
      Assigned toNone=>sveinung
      Planned Release=>3.0.0, 2.6.0
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup