patchFreeciv - Patches: patch #3737, Make get_defense_power() static

Show feedback again

patch #3737: Make get_defense_power() static

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Fri 22 Feb 2013 09:04:14 AM UTC  
Category: generalPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.5.0

Add a New Comment (Rich MarkupRich Markup):

You are not logged in

Please log in, so followups can be emailed to you.


Wed 27 Feb 2013 06:57:10 AM UTC, SVN revision 22453:

Made get_defense_power() static as it will not work with road type rivers
as it used to work with river specials.

See patch #3737

(Browse SVN revision 22453)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri 22 Feb 2013 09:04:14 AM UTC, original submission:

get_defense_power() will not handle rivers as road types. Add comment to its function header about that behavior change, and make the function static so it's less likely to get accidentally used with assumption that it handles rivers too.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.


(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):

Attached Files


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.


    Error: not logged in



    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 27 Feb 2013 06:57:24 AM UTCcazfiStatusReady For Test=>Done
      Assigned toNone=>cazfi
    Fri 22 Feb 2013 09:04:14 AM UTCcazfiAttached File-=>Added StaticGetDefensePower.patch, #17313
    Show feedback again

    Back to the top

    Powered by Savane 3.1-cleanup