patchFreeciv - Patches: patch #3755, Road type output increase...

 
 
Show feedback again

patch #3755: Road type output increase regardless of terrain

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Tue 26 Feb 2013 04:31:30 PM UTC  
 
Category: generalPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 06 Mar 2013 05:29:46 AM UTC, SVN revision 22481:

Added second set of output increase fields for road types, these ones
applying regardless of terrain.

See patch #3755

(Browse SVN revision 22481)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 27 Feb 2013 09:14:05 PM UTC, comment #2:

Also, as it's over a year since last ruleset capstr capability bump, I plan to do one in the same commit as this change goes in.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 27 Feb 2013 08:01:12 PM UTC, comment #1:

Attached patch solves this by adding second set of output increase entries for road types, these ones applying regardless of terrain.

I decided that this is not only more flexible, but also cleaner solution than having road type flag describing how the output increase values behave.

(file #17367)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Tue 26 Feb 2013 04:31:30 PM UTC, original submission:

This ticket is about resolving one remaining problem in converting river specials as road types.

Currently road types have <output>_incr values and terrain types road_<output>_incr_pct values. For given road type on given terrain these are multiplied to get the actual increase.

Classic rulesets have trade increase for Roads on certain terrains. This is currently converted to gen-roads as having terrain specific pct as 100% for terrains where increase happens and 0% where it does not.
At the same time these rulesets have trade increase for Rivers, which applies on all terrains. That is: Road increase happens on different terrains than River increase, while our current format supports only same terrain specific modifier to be used for all road types.

I'm still evaluating which way to resolve this is most sensible. Certainlty we are not going to 3D table of (terrain type/road type/output type) bonuses.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #17367:  RoadConstIncr.patch added by cazfi (14kB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 06 Mar 2013 05:30:02 AM UTCcazfiStatusReady For Test=>Done
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Wed 27 Feb 2013 08:01:12 PM UTCcazfiAttached File-=>Added RoadConstIncr.patch, #17367
      StatusNone=>Ready For Test
    Tue 26 Feb 2013 04:36:51 PM UTCcazfiSummaryRoad type out increase regardless of terrain=>Road type output increase regardless of terrain
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup