patchFreeciv - Patches: patch #3762, Make partisan appearance depend on...

 
 
Show feedback again

patch #3762: Make partisan appearance depend on nationality

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Thu Feb 28 04:21:11 2013  
 
Category: generalPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.5.0Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sun Mar 17 15:09:24 2013, SVN revision 22522:

Fixes to already committed change to make partisan appearance depend
on nationality.
- Jacob Nevins noted that ruleset loading expected partisan_pct instead
of partisans_pct from ruleset. Fixed.
- Updated README.ruleset_experimental

See patch #3762

(Browse SVN revision 22522)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu Mar 14 21:37:56 2013, comment #6:

Make it plural everywhere, and update README.ruleset_experimental.

(file #17433)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu Mar 14 09:45:03 2013, comment #5:

Um, plural, I guess.

Jacob Nevins <jtn>
Project Administrator
Wed Mar 13 05:17:23 2013, comment #4:

> ruleset.c looks for "citizen.partisan_pct" (singular), but
> what's been added to supplied rulesets is "partisans_pct"
> (plural).


Which one you think we should make the only correct one?

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Tue Mar 12 09:44:45 2013, comment #3:

Noticed in passing: ruleset.c looks for "citizen.partisan_pct" (singular), but what's been added to supplied rulesets is "partisans_pct" (plural).

Jacob Nevins <jtn>
Project Administrator
Sun Mar 10 22:28:17 2013, SVN revision 22507:

When nationality is enabled, partisan appearance depends on number of
citizens of old owner's nationality in the city instead of city's original
builder information. Partisans can appear if there's at least minimum
percentage, defined in ruleset, such citizens. If the percentage is
defined to be 0, original builder information is used instead.

See patch #3762

(Browse SVN revision 22507)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri Mar 8 06:39:33 2013, comment #1:

This patch adds citizen.partisan_pct cities.ruleset field. If nationality is enabled in general and this value > 0, at least that percentage of citizens in the city must be of old owner's nationality for partisans to be inspired. If nationality in general is not enabled, or this is 0, original city founder information is used like it used to be. For partisans never to appear simply define no partisan units in the ruleset.

This is disabled (0) in all rulesets except experimental where it's 75%.

(file #17408)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu Feb 28 04:21:11 2013, original submission:

When nationality is enabled, partisan appearance upon city conquest should depend on citizens of the city being mostly (maybe ruleset defined %) nationality of the former oẃner.

This is harder to implement than I though as part of the partisan creation is moved out to lua-script.
IMHO that's not something that should be defined in ruleset (lua-script) as it anyway depends on hardcoded properties - there's no real freedom in creation of that script fragment but it must be almost what it is in every ruleset. (There might be difference in what each maintainer considers default.lua to be. To me it's part of the ruleset and should make sense in that context. To someone else it might be just part of freeciv server implemented in lua.)
Here it also makes it impossible to change partisan behavior in C-code only without changing the scripting api. There's currently no way for the lua-script to check if such a nationality condition would be fullfilled.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #17433:  partisanS.patch added by cazfi (3kB - text/x-diff)
file #17408:  PartisanPct.patch added by cazfi (7kB - text/x-diff)

 

Digest:
   patch dependencies.

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jtn (Posted a comment)
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Error: not logged in

     

     

    Follow 13 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun Mar 17 15:09:34 2013cazfiStatusReady For Test=>Done
      Open/ClosedOpen=>Closed
    Thu Mar 14 21:37:56 2013cazfiAttached File-=>Added partisanS.patch, #17433
      StatusDone=>Ready For Test
      Open/ClosedClosed=>Open
    Sun Mar 10 22:28:35 2013cazfiStatusReady For Test=>Done
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Fri Mar 8 06:39:33 2013cazfiAttached File-=>Added PartisanPct.patch, #17408
      CategoryNone=>general
      StatusNone=>Ready For Test
      Planned Release=>2.5.0
    Thu Feb 28 04:57:21 2013cazfiDependencies-=>Depends on patch #3763
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup