patchFreeciv - Patches: patch #3785, Handle lookup_tech() errors

Show feedback again

patch #3785: Handle lookup_tech() errors

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Sun 17 Mar 2013 09:15:46 PM UTC  
Category: generalPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.5.0Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):

You are not logged in

Please log in, so followups can be emailed to you.


Wed 20 Mar 2013 05:23:15 AM UTC, SVN revision 22530:

In case of lookup_tech() errors, return error from ruleset loading
instead of aborting server.

See patch #3785

(Browse SVN revision 22530)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 18 Mar 2013 10:47:31 PM UTC, comment #1:

bug #19175 discuss problems in lookup_tech() function. I'd keep that discussion separate from not-aborting-on-ruleset-errors patch series, so I'm about to commit this patch regardless.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 17 Mar 2013 09:15:46 PM UTC, original submission:

Do not error out for lookup_tech() errors, but return error from ruleset loading.

One side-effect:
Old code considered also explicit "Never" as unit tech requirement fatal error. New code considers explicit "Never" acceptable. I've considered old behavior somewhat buggish - it has not been possible to have completely unbuildable unit that is given to players only via scripting or startunits.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.


(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):

Attached Files
file #17444:  HandleLookupTech.patch added by cazfi (10kB - text/x-diff)


Depends on the following items: None found

   patch dependencies.


Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.


    Error: not logged in



    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 20 Mar 2013 05:23:41 AM UTCcazfiStatusReady For Test=>Done
      Assigned toNone=>cazfi
    Wed 20 Mar 2013 05:17:54 AM UTCcazfiDependencies-=>patch #1449 is dependent
    Sun 17 Mar 2013 09:15:46 PM UTCcazfiAttached File-=>Added HandleLookupTech.patch, #17444
    Show feedback again

    Back to the top

    Powered by Savane 3.1-cleanup