patchFreeciv - Patches: patch #3796, Make ruleset loading failure more...

 
 
Show feedback again

patch #3796: Make ruleset loading failure more visible

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Sun 24 Mar 2013 08:13:34 PM UTC  
 
Category: generalPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.5.0, 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 03 Oct 2013 09:46:54 PM UTC, SVN revision 23531:

Make it easier for user to notice ruleset loading failure leading to
old ruleset still being used, so one does not assume that new ruleset
is in use.
- Send E_LOG_FATAL to client, which usually leads to popup error dialog
- Rearranged server side output so that error notification is last thing
printed instead of being somewhere in the middle

See patch #3796

(Browse SVN revision 23531)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu 03 Oct 2013 09:46:48 PM UTC, SVN revision 23530:

Make it easier for user to notice ruleset loading failure leading to
old ruleset still being used, so one does not assume that new ruleset
is in use.
- Send E_LOG_FATAL to client, which usually leads to popup error dialog
- Rearranged server side output so that error notification is last thing
printed instead of being somewhere in the middle

See patch #3796

(Browse SVN revision 23530)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 30 Sep 2013 11:53:56 PM UTC, comment #1:

Patch attached:

Client side (for selecting ruleset from gui): E_LOG_FATAL message sent about use of fallback ruleset. This usually results in error message dialog popup

Server side: Moved existing message to be printed after all the output from adjusting settings for the ruleset so it's not lost somewhere in the middle of the output, but is the very last line of text.

(file #19120)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 24 Mar 2013 08:13:34 PM UTC, original submission:

Now that ruleset loading failures lead server just keeping using previous ruleset instead of aborting, failures should be otherwise made clear to user. It's far too easy not to notice that ruleset one requested was not loaded after all, but previous one was returned to use.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #19120:  NoticeableRSFAilure.patch added by cazfi (3kB - text/x-diff)

 

Depends on the following items: None found

Digest:
   patch dependencies.

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 03 Oct 2013 09:47:23 PM UTCcazfiStatusReady For Test=>Done
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Mon 30 Sep 2013 11:53:56 PM UTCcazfiAttached File-=>Added NoticeableRSFAilure.patch, #19120
      StatusNone=>Ready For Test
      Planned Release2.5.0=>2.5.0, 2.6.0
    Sun 24 Mar 2013 08:13:57 PM UTCcazfiDependencies-=>patch #1449 is dependent
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup