patchFreeciv - Patches: patch #3815, Provide information about unit...

 
 
Show feedback again

patch #3815: Provide information about unit class nativity in terrain help

Submitted by:  Emmet Hikory <persia>
Submitted on:  Sat 30 Mar 2013 03:46:16 PM UTC  
 
Category: clientPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.4.0, 2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Mon 29 Apr 2013 10:08:01 PM UTC, SVN revision 22791:

Removed obsolete mention of unit classes that can travel shallow ocean
tiles from static terrain.ruleset helptexts.

Patch by Emmet Hikory and Jacob Nevins

See patch #3815

(Browse SVN revision 22791)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 29 Apr 2013 10:07:56 PM UTC, SVN revision 22790:

Removed obsolete mention of unit classes that can travel shallow ocean
tiles from static terrain.ruleset helptexts.

Patch by Emmet Hikory and Jacob Nevins

See patch #3815

(Browse SVN revision 22790)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 28 Apr 2013 07:57:25 AM UTC, comment #11:

S2_4 version

(file #17837)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 24 Apr 2013 12:05:05 PM UTC, comment #10:

While we have no formal string freeze for beta2, I'd leave out patch that only changes texts (i.e, is not doing it as part of larger bugfix) now that we have 100% translations.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 24 Apr 2013 09:46:33 AM UTC, comment #9:

> Old description is redundant, but is it still something that
> makes people to realize the difference between Ocean and Deep
> Ocean while they are less likely to spot that unit class lists
> differ?

I agree. I think it's worth keeping the Deep Ocean text the way it is, but still removing the redundancy from the Ocean/Lake descriptions. New trunk patch attached.

(file #17825)

Jacob Nevins <jtn>
Project Administrator
Tue 09 Apr 2013 09:16:48 PM UTC, comment #8:

I committed the helptext generation part, but would really like more opinions of the changes to static texts. Old description is redundant, but is it still something that makes people to realize the difference between Ocean and Deep Ocean while they are less likely to spot that unit class lists differ?

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Tue 09 Apr 2013 09:12:51 PM UTC, SVN revision 22704:

Give list of native unit classes in terrain help.

Patch by Emmet Hikory

See patch #3815

(Browse SVN revision 22704)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Tue 09 Apr 2013 09:12:46 PM UTC, SVN revision 22703:

Give list of native unit classes in terrain help.

Patch by Emmet Hikory

See patch #3815

(Browse SVN revision 22703)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Tue 09 Apr 2013 09:55:44 AM UTC, comment #5:

The attached files provide one possible adjustment to the static helptexts for S2_4 and trunk. In trunk, I did not remove the phrases "Planet's radiation makes it impossible for Earthly organisms to survive here.", "Burrowing units are unable to burrow through these mountains.", or "No ship without special equipment can enter." for the alien ruleset as they were phrased in the negative, and I thought they added a nice flavour and sense of environment beyond their value as indicators of nativity. Similarly, one could add "Trireme captains fear swamping by the heavy seas, and will not enter." or so to the Deep Ocean texts for classic/experimental/multiplayer, enriching the storyline of the ruleset without overloading the nativity data provided by this patch.

(file #17723, file #17724)

Emmet Hikory <persia>
Project Member
Sun 07 Apr 2013 07:28:15 AM UTC, comment #4:

- S2_4 version that compiles

We may want to change static helptexts for some terrains too. Now "Ocean" helptext redundantly mentions that it can be traveled by sea and trireme units, and deep ocean points out that trireme cannot travel there.

(file #17694)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 01 Apr 2013 11:40:23 AM UTC, comment #3:

Seems like a fine change to me.

Jacob Nevins <jtn>
Project Administrator
Mon 01 Apr 2013 07:57:26 AM UTC, comment #2:

I didn't mean to rush processing of this patch with the comment in patch #3816 , rather I just wanted to provide a hint for testing, as when I checked the submitted patch against revision 22638 it didn't apply cleanly. Anyway, I believe that terrain-nativity-help.S2_4.patch should provide essentially the same value ported to S2_4. I was unable to build S2_4 from revision 22639 due to a LUA error (which I presume related to some local configuration on my machine), so this is entirely theoretical, rather than a tested patch.

(file #17643)

Emmet Hikory <persia>
Project Member
Mon 01 Apr 2013 07:28:12 AM UTC, comment #1:

Usually jtn has had the last say in help changes, but OTOH he may be busy with other things. Feel free to take this ticket from me if you want. Either way is fine by me.

I think S2_4 would benefit from such a help improvement.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 30 Mar 2013 03:46:16 PM UTC, original submission:

The current help provides "Land units cannot travel on oceanic terrains." as part of the helpstring for any oceanic terrain. Given the concept of terrain nativity, and that units are no longer one of Land, Sea, or Air based on UMT_LAND, UMT_SEA, and UMT_BOTH, this isn't very helpful when playing a ruleset with complex nativity.

This patch replaces that with a constructed string of unit classes that are native to that terrain without any special, base, or road. The string is reused from the code to generate the road help, which I hope will reduce the impact of the new string on translators. I would be happy to backport the patch to S2_4 or earlier, if someone believes it should also be applied there.

Emmet Hikory <persia>
Project Member

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #17825:  quick-terrain-nativity-static-help-changes-bis.patch added by jtn (3kB - text/x-diff - trunk r22757: restore deep ocean text)
file #17643:  terrain-nativity-help.S2_4.patch added by persia (1kB - application/octet-stream)
file #17614:  terrain-nativity-help.patch added by persia (2kB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jtn (Posted a comment)
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by persia (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 12 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 29 Apr 2013 10:08:11 PM UTCcazfiStatusReady For Test=>Done
      Open/ClosedOpen=>Closed
    Sun 28 Apr 2013 07:57:25 AM UTCcazfiAttached File-=>Added StaticOceanMoveHelp-S2_4.patch, #17837
    Wed 24 Apr 2013 09:46:33 AM UTCjtnAttached File-=>Added quick-terrain-nativity-static-help-changes-bis.patch, #17825
    Tue 09 Apr 2013 09:55:44 AM UTCpersiaAttached File-=>Added quick-terrain-nativity-static-help-changes.S2_4.patch, #17723
      Attached File-=>Added quick-terrain-nativity-static-help-changes.patch, #17724
    Sun 07 Apr 2013 07:28:15 AM UTCcazfiAttached File-=>Added TerrainMoveClassHelp-S2_4.patch, #17694
    Mon 01 Apr 2013 10:36:08 PM UTCcazfiPlanned Release=>2.4.0, 2.5.0
    Mon 01 Apr 2013 07:57:26 AM UTCpersiaAttached File-=>Added terrain-nativity-help.S2_4.patch, #17643
    Mon 01 Apr 2013 07:28:12 AM UTCcazfiStatusNone=>Ready For Test
      Assigned toNone=>cazfi
    Sat 30 Mar 2013 03:46:16 PM UTCpersiaAttached File-=>Added terrain-nativity-help.patch, #17614
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup