patchFreeciv - Patches: patch #3841, Add strings for negated...

 
 
Show feedback again

patch #3841: Add strings for negated requirements

Submitted by:  Emmet Hikory <persia>
Submitted on:  Mon 08 Apr 2013 02:03:29 PM UTC  
 
Category: clientPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Jacob Nevins <jtn>Open/Closed: Closed
Planned Release: 2.4.3, 2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Wed 23 Apr 2014 08:20:36 PM UTC, SVN revision 24793:

Added helptext descriptions for negated requirements.

Patch by Emmet Hikory (persia@gna).

See gna patch #3841.

(Browse SVN revision 24793)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Tue 22 Apr 2014 12:06:58 AM UTC, comment #7:

Backported patch for S2_4 attached. (Touches 33 strings.)

(file #20550)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Mon 21 Apr 2014 12:09:20 PM UTC, comment #6:

> Yes, I now don't plan patch #4400 or this for 2.4.2.

I do still plan to backport this to S2_4, though, due to its effect on civ2civ3 online help. Re-opening and optimistically setting 2.4.3 target.

(I may not bother with patch #4400, though.)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Wed 22 Jan 2014 09:55:11 PM UTC, comment #5:

Yes, I now don't plan patch #4400 or this for 2.4.2.

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Wed 22 Jan 2014 07:40:11 PM UTC, comment #4:

> I'm probably going to want to backport this to S2_4 as part of
> the effort to support negated requirements.


What's the plan now? This currently has 2.4.2 as planned release, which it probabaly shouldn't.

Marko Lindqvist <cazfi>
Project Administrator
Fri 03 Jan 2014 07:43:02 PM UTC, comment #3:

At least notify i18n list so those who have already translated those strings in S2_5 know to consider merge from there. Is there more we can do to ease that?

Marko Lindqvist <cazfi>
Project Administrator
Fri 03 Jan 2014 07:33:28 PM UTC, comment #2:

I'm probably going to want to backport this to S2_4 as part of the effort to support negated requirements. Currently, civ2civ3 online help is actively misleading because of this.

This means lots of string changes (and I'll probably do even more in patch #4400; that way at least most translators don't see two lots of churn).

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Tue 16 Apr 2013 09:43:07 PM UTC, SVN revision 22724:

Added helptext descriptions for negated requirements.

Patch by Emmet Hikory

See patch #3841

(Browse SVN revision 22724)

Marko Lindqvist <cazfi>
Project Administrator
Mon 08 Apr 2013 02:03:29 PM UTC, original submission:

As discussed on freeciv-dev and freeciv-i18n, attached is a patch that provides alternate help strings if a given requirement is negated. This depends on patch #3836.

The patch compiles and the diff looked sane to me, but I haven't tested all the conditions: more eyes are welcome (455 insertions, 153 deletions), as would be a volunteer who had a ruleset that exercised everything and was willing to verify the helptext.

Emmet Hikory <persia>
Project Member

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #20550:  S2_4-negated-requirement-help.patch added by jtn (25kB - text/x-patch - S2_4 r24787)
file #17716:  negated-requirement-help.patch added by persia (37kB - application/octet-stream)

 

Depends on the following items: None found

Digest:
   bug dependencies, patch dependencies.

 

Carbon-Copy List
  • -unavailable- added by jtn (Posted a comment)
  • -unavailable- added by cazfi (Updated the item)
  • -unavailable- added by persia (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 17 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 23 Apr 2014 08:22:20 PM UTCjtnOpen/ClosedOpen=>Closed
    Tue 22 Apr 2014 12:06:58 AM UTCjtnAttached File-=>Added S2_4-negated-requirement-help.patch, #20550
    Mon 21 Apr 2014 12:09:20 PM UTCjtnOpen/ClosedClosed=>Open
      Planned Release2.5.0=>2.4.3, 2.5.0
    Sat 12 Apr 2014 08:55:20 PM UTCcazfiOpen/ClosedOpen=>Closed
      Planned Release2.4.3,2.5.0,2.6.0=>2.5.0
    Wed 22 Jan 2014 09:55:11 PM UTCjtnPlanned Release2.4.2,2.5.0=>2.4.3,2.5.0,2.6.0
    Fri 03 Jan 2014 07:33:28 PM UTCjtnAssigned tocazfi=>jtn
      Open/ClosedClosed=>Open
      Planned Release2.5.0=>2.4.2,2.5.0
    Fri 03 Jan 2014 07:32:23 PM UTCjtnDependencies-=>patch #4400 is dependent
    Tue 16 Apr 2013 09:43:17 PM UTCcazfiStatusReady For Test=>Done
      Open/ClosedOpen=>Closed
    Fri 12 Apr 2013 08:02:05 AM UTCcazfiStatusNone=>Ready For Test
      Assigned toNone=>cazfi
      Planned Release=>2.5.0
    Mon 08 Apr 2013 02:03:29 PM UTCpersiaAttached File-=>Added negated-requirement-help.patch, #17716
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup