patchBattle for Wesnoth - Patches: patch #3847, Added support of notifications for...

 
 
Show feedback again

patch #3847: Added support of notifications for Windows

Submitted by:  Maxim Biro <nurupo>
Submitted on:  Sat Apr 13 03:42:04 2013  
 
Priority: 5 - NormalStatus: None
Privacy: PublicAssigned to: Sergey Popov <loonycyborg>
Open/Closed: Closed

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sat May 18 20:20:03 2013, comment #7:

The patch was modified and committed to the repository.
https://github.com/wesnoth/wesnoth-old/commit/2fc758377a566ce6a3d6cdd7d30ca5076e8395c0

Maxim Biro <nurupo>
Sat May 18 20:18:45 2013, comment #6:

This patch thread continued as a pull request:
https://github.com/wesnoth/wesnoth-old/pull/13
Closing.

Anonymissimus <anonymissimus>
Project Member
Fri May 17 17:25:53 2013, comment #5:

Noticed there was something wrong with the patch.

(file #17974)

Maxim Biro <nurupo>
Tue May 14 03:54:16 2013, comment #4:

Modified the patch so it would compile on mingw.
In the patch I assumed that Wesnoth targets Windows XP and higher. If it also targets Windows 2000 or Windows 98, some changes should be done.
Since I introduced two new files, they should be added to all project files/cmake_lists and etc. I don't know how to make a conditional include (based on OS) for all different kinds of project files that are out there. As a suggestion, the two files can be simply wrapped into `#ifdef _WIN32` `#endif` directives and added unconditionally.

(file #17966)

Maxim Biro <nurupo>
Mon Apr 15 01:11:50 2013, comment #3:

I can deal with build system issues myself too, if necessary

Sergey Popov <loonycyborg>
Project MemberIn charge of this item.
Sun Apr 14 15:52:40 2013, comment #2:

Other developers pointed me out that the are a few fixes I have to make, so please don't integrate it yet.

Maxim Biro <nurupo>
Sun Apr 14 12:26:19 2013, comment #1:

I'll try to integrate this once we'll finish moving repos around between hosting services. Note that I'm using mingw toolchain to make windows releases.

Sergey Popov <loonycyborg>
Project MemberIn charge of this item.
Sat Apr 13 03:42:04 2013, original submission:

Basically, you can now show notifications on Windows.

There is a limit on notification title and message lengths, if title and message don't fit in WinApi limitations, they get truncated in order to fit.

Also, when users click on the notification, they get switched to the Wesnoth game window.

I have tested it only on Windows7 and would like someone else to test it on Windows [8|7|Vista|XP].

Pretty pictures attached :)

Maxim Biro <nurupo>

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #17974:  windows_tray_notification_v3.patch added by nurupo (11kB - application/octet-stream)
file #17966:  windows_tray_notification_v2.patch added by nurupo (12kB - application/octet-stream)
file #17742:  windows_tray_notification.patch added by nurupo (12kB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by anonymissimus (Posted a comment)
  • -unavailable- added by loonycyborg (Updated the item)
  • -unavailable- added by nurupo (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Error: not logged in

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat May 18 20:18:45 2013anonymissimusOpen/ClosedOpen=>Closed
    Fri May 17 17:25:52 2013nurupoAttached File-=>Added windows_tray_notification_v3.patch, #17974
    Tue May 14 03:54:16 2013nurupoAttached File-=>Added windows_tray_notification_v2.patch, #17966
    Sun Apr 14 12:20:53 2013loonycyborgAssigned toNone=>loonycyborg
    Sat Apr 13 03:42:04 2013nurupoAttached File-=>Added notification_example_01.png, #17741
      Attached File-=>Added windows_tray_notification.patch, #17742
      Attached File-=>Added notification_example_02.png, #17743
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup