patchFreeciv - Patches: patch #3867, Drop map_move_cost_ai()

Show feedback again

patch #3867: Drop map_move_cost_ai()

Submitted by:  Emmet Hikory <persia>
Submitted on:  Mon Apr 22 00:26:18 2013  
Category: generalPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.5.0Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):

You are not logged in

Please log in, so followups can be emailed to you.


Tue Apr 30 21:22:57 2013, SVN revision 22797:

Dropped obsolete map_move_cost_ai().

Patch by Emmet Hikory

See patch #3867

(Browse SVN revision 22797)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon Apr 22 00:26:18 2013, original submission:

This function checked for moves involving sea tiles, but otherwise behaved precisely like map_move_cost(). The only remaining caller (aiferry.c:combined_land_sea_move()) contains parallel logic ensuring that map_move_cost_ai was never called with either source or destination as an ocean tile. As a result, it is safe for combined_land_sea_move() to call map_move_cost() directly, so this function may be removed.

Emmet Hikory <persia>
Project Member


(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):

Attached Files
file #17799:  drop-map_move_cost_ai.patch added by persia (4kB - application/octet-stream)


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -unavailable- added by cazfi (Updated the item)
  • -unavailable- added by persia (Submitted the item)

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.


    Error: not logged in



    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue Apr 30 21:23:07 2013cazfiStatusReady For Test=>Done
    Sat Apr 27 23:40:22 2013cazfiStatusNone=>Ready For Test
      Assigned toNone=>cazfi
      Planned Release=>2.5.0
    Mon Apr 22 00:26:18 2013persiaAttached File-=>Added drop-map_move_cost_ai.patch, #17799
    Show feedback again

    Back to the top

    Powered by Savane 3.1-cleanup