patchFreeciv - Patches: patch #3870, New base to base_owner(), not...

 
 
Show feedback again

patch #3870: New base to base_owner(), not tile_owner()

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Mon 22 Apr 2013 12:45:01 AM UTC  
 
Category: generalPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 12 Apr 2014 09:15:22 PM UTC, comment #5:

> Dropped tile_clear_unsupported_infrastructure()


This was actually patch #3865

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu 25 Apr 2013 07:43:15 PM UTC, SVN revision 22759:

Dropped tile_clear_unsupported_infrastructure()

Patch by Emmet Hikory

See patch #3870

(Browse SVN revision 22759)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu 25 Apr 2013 07:42:07 AM UTC, SVN revision 22758:

When new base is created, it's claimed by base_owner(), not tile_owner()

See patch #3870

(Browse SVN revision 22758)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 22 Apr 2013 06:57:24 AM UTC, comment #2:

Yes, though the main reason I'm working on this area is to provide ownership for bases even if terrain is not owned at all. See bug #16385 for example (there's other related tickets)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 22 Apr 2013 01:29:51 AM UTC, comment #1:

Do I read this correctly as providing a framework for a future feature allowing one player to own a base in another player's territory?

Emmet Hikory <persia>
Project Member
Mon 22 Apr 2013 12:45:01 AM UTC, original submission:

Fix creation of non-terrain-claiming bases to get claim base for base_owner(), not tile_owner().
At the moment this makes no functional difference as base_owner() is just wrapper for tile_owner().

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #17802:  BaseOwnerClaims.patch added by cazfi (495B - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by persia (Posted a comment)
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 25 Apr 2013 07:42:24 AM UTCcazfiStatusReady For Test=>Done
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Mon 22 Apr 2013 12:45:01 AM UTCcazfiAttached File-=>Added BaseOwnerClaims.patch, #17802
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup