patchFreeciv - Patches: patch #3889, [Metaticket] Fix things deprecated...

 
 
Show feedback again

patch #3889: [Metaticket] Fix things deprecated in gtk+-3.4 (oldest supported) already

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Tue 30 Apr 2013 11:07:05 PM UTC  
 
Category: client-gtk-3.0Priority: 5 - Normal
Status: NonePrivacy: Public
Assigned to: NoneOpen/Closed: Open
Planned Release: 

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 01 May 2013 05:03:11 PM UTC, comment #3:

One other thing regarding patch #3560:
while there is gtk_button_set_always_show_image, it's only since 3.6 and IMHO title of the button is descriptive enough in the context anyway if one has a theme that turns off images on buttons.

As for gtk_rc_get_theme_dir, my description was not quite precise - see "Default files" section of GtkCssProvider docs.

Rafał Mużyło <galtgendo>
Wed 01 May 2013 03:50:27 AM UTC, comment #2:

In random order:

- gtk_rc_get_theme_dir is an annoyance: it was a concept change in gtk3, css themes are read from by default from paths hardcoded on (gtk+) build time (i.e. ${prefix}/share/themes), so there's no real equivalent for it
- create_cma_dialog got stuck in patch #3560 (again, IMHO, that upstream setting is not much different than freeciv small display settings)
- citydlg.c:2799:3 and cityrep.c:1437:3 go back to what I've wrote in i.e. bug #20097 - silencing those warnings would be easy, writing a proper fix - not so
- mapctrl.c set is patch #3550 and this one should be a proper fix

Rafał Mużyło <galtgendo>
Tue 30 Apr 2013 11:41:27 PM UTC, comment #1:

Attached is deprecation warnings from current TRUNK when built against gtk+-3.4.0.

(file #17867)

Marko Lindqvist <cazfi>
Project Administrator
Tue 30 Apr 2013 11:07:05 PM UTC, original submission:

gtk3-client uses number of constructs that are deprecated in the oldest supported version, 3.4, already. Those should be replaced with more modern constructs.

Marko Lindqvist <cazfi>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #17867:  stderr.log added by cazfi (2kB - text/x-log)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follows 1 latest change.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 30 Apr 2013 11:41:27 PM UTCcazfiAttached File-=>Added stderr.log, #17867
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup