patchFreeciv - Patches: patch #3897, Respect slow_invasions in...

 
 
Show feedback again

patch #3897: Respect slow_invasions in pathfinding

Submitted by:  Emmet Hikory <persia>
Submitted on:  Mon 06 May 2013 09:14:50 AM UTC  
 
Category: aiPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: pepeto <pepeto>Open/Closed: Closed
Planned Release: 2.5.0,2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Thu 23 Jan 2014 09:06:10 PM UTC, SVN revision 24221:

Respect slow_invasions in pathfinding.

Patch by Emmet Hikory (persia@gna)

See gna patch #3897

(Browse SVN revision 24221)

pepeto <pepeto>
Project MemberIn charge of this item.
Thu 23 Jan 2014 09:06:01 PM UTC, SVN revision 24220:

Respect slow_invasions in pathfinding.

Patch by Emmet Hikory (persia@gna)

See gna patch #3897

(Browse SVN revision 24220)

pepeto <pepeto>
Project MemberIn charge of this item.
Mon 20 Jan 2014 11:20:47 PM UTC, comment #4:

Not truncated version for trunk and version for S2_5 attached.

(file #19808, file #19809)

pepeto <pepeto>
Project MemberIn charge of this item.
Mon 13 Jan 2014 10:47:01 PM UTC, comment #3:

Updated patch against current trunk.

(file #19743)

pepeto <pepeto>
Project MemberIn charge of this item.
Wed 08 Jan 2014 12:10:47 PM UTC, comment #2:

I have read your patch very closely. There were some parts I couldn't understand, now I got it!

Ready for test.

pepeto <pepeto>
Project MemberIn charge of this item.
Wed 08 May 2013 10:14:56 PM UTC, comment #1:

New version of the patch to apply over updated #3886 including disembark charge.

(file #17932)

Emmet Hikory <persia>
Project Member
Mon 06 May 2013 09:14:50 AM UTC, original submission:

Improved slow_invasions handling for pathfinding extracted from prior revision of patch #3886 (upon which this depends - not functionally, but syntactially (the indentation and placement of the FC_INFINITY handling changed in that patch)).

This implementation is far simpler and contains conditional logic to prevent the prior reported hang (moves_left%move_rate may be 0, which isn't a good value to use for cost, unless provided by map_move_cost()).

Also included is another conditional in igter_move_unit() to correctly penalise UTYF_IGTER units when slow_invasions is configured.

Emmet Hikory <persia>
Project Member

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #19743:  pf_slow_invasions.diff added by pepeto (2kB - text/x-diff)
file #17898:  respect-slow_invasions.patch added by persia (3kB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by pepeto (Updated the item)
  • -unavailable- added by persia (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 10 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 23 Jan 2014 09:06:32 PM UTCpepetoStatusReady For Test=>Done
      Open/ClosedOpen=>Closed
    Mon 20 Jan 2014 11:20:47 PM UTCpepetoAttached File-=>Added trunk_slow_invasions.diff, #19808
      Attached File-=>Added S2_5_pf_slow_invasions.diff, #19809
    Mon 13 Jan 2014 10:47:01 PM UTCpepetoAttached File-=>Added pf_slow_invasions.diff, #19743
    Wed 08 Jan 2014 12:10:47 PM UTCpepetoStatusNone=>Ready For Test
      Planned Release=>2.5.0,2.6.0
    Wed 22 May 2013 11:55:16 AM UTCpepetoAssigned toNone=>pepeto
    Wed 08 May 2013 10:14:56 PM UTCpersiaAttached File-=>Added respect-slow_invasions+disembark-rebase.patch, #17932
    Mon 06 May 2013 09:14:50 AM UTCpersiaAttached File-=>Added respect-slow_invasions.patch, #17898
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup