patchFreeciv - Patches: patch #3897, Respect slow_invasions in...

Show feedback again

patch #3897: Respect slow_invasions in pathfinding

Submitted by:  Emmet Hikory <persia>
Submitted on:  Mon May 6 09:14:50 2013  
Category: aiPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: pepeto <pepeto>Open/Closed: Closed
Planned Release: 2.5.0,2.6.0Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):

You are not logged in

Please log in, so followups can be emailed to you.


(Jump to the original submission Jump to the original submission)

Thu Jan 23 21:06:10 2014, SVN revision 24221:

Respect slow_invasions in pathfinding.

Patch by Emmet Hikory (persia@gna)

See gna patch #3897

(Browse SVN revision 24221)

pepeto <pepeto>
Project MemberIn charge of this item.
Thu Jan 23 21:06:01 2014, SVN revision 24220:

Respect slow_invasions in pathfinding.

Patch by Emmet Hikory (persia@gna)

See gna patch #3897

(Browse SVN revision 24220)

pepeto <pepeto>
Project MemberIn charge of this item.
Mon Jan 20 23:20:47 2014, comment #4:

Not truncated version for trunk and version for S2_5 attached.

(file #19808, file #19809)

pepeto <pepeto>
Project MemberIn charge of this item.
Mon Jan 13 22:47:01 2014, comment #3:

Updated patch against current trunk.

(file #19743)

pepeto <pepeto>
Project MemberIn charge of this item.
Wed Jan 8 12:10:47 2014, comment #2:

I have read your patch very closely. There were some parts I couldn't understand, now I got it!

Ready for test.

pepeto <pepeto>
Project MemberIn charge of this item.
Wed May 8 22:14:56 2013, comment #1:

New version of the patch to apply over updated #3886 including disembark charge.

(file #17932)

Emmet Hikory <persia>
Project Member
Mon May 6 09:14:50 2013, original submission:

Improved slow_invasions handling for pathfinding extracted from prior revision of patch #3886 (upon which this depends - not functionally, but syntactially (the indentation and placement of the FC_INFINITY handling changed in that patch)).

This implementation is far simpler and contains conditional logic to prevent the prior reported hang (moves_left%move_rate may be 0, which isn't a good value to use for cost, unless provided by map_move_cost()).

Also included is another conditional in igter_move_unit() to correctly penalise UTYF_IGTER units when slow_invasions is configured.

Emmet Hikory <persia>
Project Member


(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):

Attached Files
file #19743:  pf_slow_invasions.diff added by pepeto (2kB - text/x-diff)
file #17898:  respect-slow_invasions.patch added by persia (3kB - application/octet-stream)


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -unavailable- added by pepeto (Updated the item)
  • -unavailable- added by persia (Submitted the item)

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.


    Error: not logged in



    Follow 10 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu Jan 23 21:06:32 2014pepetoStatusReady For Test=>Done
    Mon Jan 20 23:20:47 2014pepetoAttached File-=>Added trunk_slow_invasions.diff, #19808
      Attached File-=>Added S2_5_pf_slow_invasions.diff, #19809
    Mon Jan 13 22:47:01 2014pepetoAttached File-=>Added pf_slow_invasions.diff, #19743
    Wed Jan 8 12:10:47 2014pepetoStatusNone=>Ready For Test
      Planned Release=>2.5.0,2.6.0
    Wed May 22 11:55:16 2013pepetoAssigned toNone=>pepeto
    Wed May 8 22:14:56 2013persiaAttached File-=>Added respect-slow_invasions+disembark-rebase.patch, #17932
    Mon May 6 09:14:50 2013persiaAttached File-=>Added respect-slow_invasions.patch, #17898
    Show feedback again

    Back to the top

    Powered by Savane 3.1-cleanup