patchFreeciv - Patches: patch #3904, Fix auto-settler mode breaking...

 
 
Show feedback again

patch #3904: Fix auto-settler mode breaking when units travel through transports

Submitted by:  Guillaume Melquiond <silene>
Submitted on:  Sat 11 May 2013 01:21:59 PM UTC  
 
Category: NonePriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.3.5, 2.4.0, 2.5.0, 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 25 May 2013 08:32:12 AM UTC, SVN revision 22892:

Do not clear autosettler status when it moves through transport.

Patch by Guillaume Melquiond

See patch #3904

(Browse SVN revision 22892)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 25 May 2013 08:31:56 AM UTC, SVN revision 22891:

Do not clear autosettler status when it moves through transport.

Patch by Guillaume Melquiond

See patch #3904

(Browse SVN revision 22891)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 25 May 2013 08:31:45 AM UTC, SVN revision 22890:

Do not clear autosettler status when it moves through transport.

Patch by Guillaume Melquiond

See patch #3904

(Browse SVN revision 22890)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 25 May 2013 08:31:32 AM UTC, SVN revision 22889:

Do not clear autosettler status when it moves through transport.

Patch by Guillaume Melquiond

See patch #3904

(Browse SVN revision 22889)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 11 May 2013 01:21:59 PM UTC, original submission:

When an engineer in auto-settler mode travels through a boat to reach its target tile, it reverts back to manual control.

What happens is the following. When the unit is loaded in the boat, its activity is set to sentry by the server (unittools:3386). Then the client automatically wakes up the unit when it leaves the boat. Finally the server disables AI-control because it believes the player has taken over (unithand:747).

The bug could be fixed at several places along this chain of events. I choose to fix at the first place. Indeed, notice that transported units are never changed into sentry if they are either controlled by an AI player or given orders by a human player. So the fix is a one-liner there: extend this logic to AI-controlled human-player units, since they are no different.

Guillaume Melquiond <silene>

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #17952:  autosettler.patch added by silene (521B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Updated the item)
  • -unavailable- added by silene (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 25 May 2013 08:32:15 AM UTCcazfiStatusReady For Test=>Done
      Open/ClosedOpen=>Closed
    Mon 20 May 2013 07:58:02 AM UTCcazfiStatusNone=>Ready For Test
      Assigned toNone=>cazfi
      Planned Release=>2.3.5, 2.4.0, 2.5.0, 2.6.0
    Sat 11 May 2013 01:21:59 PM UTCsileneAttached File-=>Added autosettler.patch, #17952
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup