patchBattle for Wesnoth - Patches: patch #3914, Using scoped_ptr in unit class...

 
 
Show feedback again

patch #3914: Using scoped_ptr in unit class (refactor)

Submitted by:  Vinícius dos Santos Oliveira <vinipsmaker>
Submitted on:  Fri 17 May 2013 06:57:34 PM UTC  
 
Priority: 5 - NormalStatus: Done
Privacy: PublicAssigned to: Alexander van Gessel <ai0867>
Open/Closed: Closed

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 26 May 2013 09:20:27 PM UTC, comment #3:

I've merged the pull request. (and was just informed of the existence of this patch by anonymissimus)

Alexander van Gessel <ai0867>
Project MemberIn charge of this item.
Sat 18 May 2013 11:32:11 PM UTC, comment #2:

> Umm, pls don't duplicate in this direction I'd say. Pull requests are certainly the better option.


I wasn't sure, because developers seem to have splitted opinions.

Vinícius dos Santos Oliveira <vinipsmaker>
Sat 18 May 2013 08:23:41 PM UTC, comment #1:

Umm, pls don't duplicate in this direction I'd say. Pull requests are certainly the better option.

Anonymissimus <anonymissimus>
Project Member
Fri 17 May 2013 06:57:34 PM UTC, original submission:

I've sent the patch to https://github.com/wesnoth/wesnoth-old/pull/5 .

Quoting message from the previous link:
"This change aims to simplify the code, making the intents more explicit.
There wasn't a memory leak in the previous version, but it could easily be
introduced in the future.

Also, RAII is part of the coding standards of Wesnoth, as noted in the wiki.

There are other raw pointers in the unit class, but unit don't own them, then
I leave them unchanged."

Vinícius dos Santos Oliveira <vinipsmaker>

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by shadowmaster (Updated the item)
  • -unavailable- added by ai0867 (Posted a comment)
  • -unavailable- added by anonymissimus (Posted a comment)
  • -unavailable- added by vinipsmaker (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 06 Aug 2013 12:41:20 AM UTCshadowmasterOpen/ClosedOpen=>Closed
    Sun 26 May 2013 09:20:27 PM UTCai0867StatusNone=>Done
      Assigned toNone=>ai0867
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup