patchFreeciv - Patches: patch #3930, Case-insensitive string...

Show feedback again

patch #3930: Case-insensitive string comparisons with icu

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Thu 30 May 2013 07:01:00 PM UTC  
Category: generalPriority: 5 - Normal
Status: Ready For TestPrivacy: Public
Assigned to: NoneOpen/Closed: Open
Planned Release: 3.0.0

Add a New Comment (Rich MarkupRich Markup):

You are not logged in

Please log in, so followups can be emailed to you.


Mon 27 Apr 2015 05:12:45 PM UTC, comment #2:

- As the initial buffer size no longer acts as hardcoded maximum, there's no need to make it so overly huge compared to expected usage. Reduce it from 1024 (+1) to 255 (+1) bytes

(file #24376)

Marko Lindqvist <cazfi>
Project Administrator
Mon 27 Apr 2015 05:57:10 AM UTC, comment #1:

- Support comparison of strings longer than 1024 bytes (now limited by the available memory only)

(file #24369)

Marko Lindqvist <cazfi>
Project Administrator
Thu 30 May 2013 07:01:00 PM UTC, original submission:

Use icu for for case insensitive string comparisons. This is likely to fix some never noticed bugs in comparisons when there's different multibyte character in compared strings.

Marko Lindqvist <cazfi>
Project Administrator


(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):

Attached Files
file #24376:  IcuCaseCmp-3.patch added by cazfi (6kB - text/plain-diff)
file #24369:  IcuCaseCmp-2.patch added by cazfi (6kB - text/plain-diff)
file #18031:  IcuCaseCmp.patch added by cazfi (3kB - text/x-diff)


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.


    Please enter the title of George Orwell's famous dystopian book (it's a date):



    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 27 Apr 2015 05:12:45 PM UTCcazfiAttached File-=>Added IcuCaseCmp-3.patch, #24376
    Mon 27 Apr 2015 05:57:10 AM UTCcazfiAttached File-=>Added IcuCaseCmp-2.patch, #24369
    Tue 21 Apr 2015 04:36:22 PM UTCcazfiPlanned Release=>3.0.0
    Sun 04 Jan 2015 04:10:52 AM UTCcazfiPlanned Release2.6.0=>
    Thu 30 May 2013 07:01:00 PM UTCcazfiAttached File-=>Added IcuCaseCmp.patch, #18031
    Show feedback again

    Back to the top

    Powered by Savane 3.1-cleanup