patchFreeciv - Patches: patch #3941, Building obsolescense requirement...

 
 
Show feedback again

patch #3941: Building obsolescense requirement vector

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Sat Jun 15 05:20:27 2013  
 
Category: generalPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.6.0Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue Jun 25 23:59:39 2013, SVN revision 22975:

Made building "obsolete_by" requirement vector. If any of these
obsoleting requirements is fulfilled, building is obsolete.

See patch #3941

(Browse SVN revision 22975)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed Jun 19 17:40:52 2013, comment #1:

I was interested to make Great wonders obsolete by techs with range "Player" (instead of default "World"). I guess it will possible with this patch, thank you.

David Fernandez <bardo>
Sat Jun 15 05:20:27 2013, original submission:

Make building "obsolete_by" vector of requirements. If any of these requirements is fulfilled, building is obsolete.

The original use-case I made this for could be achieved with much less flexible solution, but I see no reason not to go all the way to full requirement vector. Old code with single tech requirement had "range" behavior hardcoded so that for Great Wonders anybody having the tech obsoleted the wonder (range "World"), and for Small Wonders and normal buildings it was owner having the tech (range "Player"). I wanted to have specific wonder as Small Wonder so that all players could have their own, but it getting obsoleted globally when first player gets relevant tech.

All supplied rulesets should give identical behavior to old. This includes the fact that wonders in multiplayer ruleset, where they all are Small Wonders, do not get globally obsoleted. I leave it to future tickets if that should be changed or not.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #18090:  ObsoleteReqVec.patch.bz2 added by cazfi (11kB - application/x-bzip)

 

Depends on the following items: None found

Digest:
   patch dependencies.

 

Carbon-Copy List
  • -unavailable- added by bardo (Posted a comment)
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Error: not logged in

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu Jan 2 17:11:31 2014jtnDependencies-=>patch #1341 is dependent
    Tue Jun 25 23:59:54 2013cazfiStatusReady For Test=>Done
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Sat Jun 15 05:20:27 2013cazfiAttached File-=>Added ObsoleteReqVec.patch.bz2, #18090
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup