patchBattle for Wesnoth - Patches: patch #3972, Fix for bug #20900: Game hangs if...

Show feedback again

patch #3972: Fix for bug #20900: Game hangs if bad argument to --screenshot command line option is provided.

Submitted by:  Patryk Obara <dreamer_>
Submitted on:  Fri Jul 5 04:27:31 2013  
Priority: 5 - NormalStatus: None
Privacy: PublicAssigned to: None
Open/Closed: Open

Add a New Comment (Rich MarkupRich Markup):

You are not logged in

Please log in, so followups can be emailed to you.


Fri Jul 5 04:27:31 2013, original submission:

copy of commit message:

Fix error handling for map loading when --screenshot option
is passed

This is fix for bug #20900: Game hangs if bad argument to
--screenshot command line option is provided.

Bug was caused by exception handling in context_manager::load_map.
When map file failed to load, transient message was requested from
(hidden) gui, which caused gui loop to start.

Fix consists of:
- context_manager::load_map accepts new flag to indicate if it should
run with gui or not
- fix editor::start to properly handle screenshot usecase
- added text logging for (un)successfull screenshot creation
- fix exception unsafe code in editor::start
changelog | 2 ++
src/editor/editor_controller.cpp | 3 ++-
src/editor/editor_main.cpp | 51 +++++++++++++++++++++++++++++---------
src/editor/map/context_manager.cpp | 18 ++++++++------
src/editor/map/context_manager.hpp | 3 +--
5 files changed, 55 insertions(+), 22 deletions(-)

Patryk Obara <dreamer_>


(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -unavailable- added by fendrin (Updated the item)
  • -unavailable- added by vultraz (Updated the item)
  • -unavailable- added by dreamer_ (Submitted the item)
  • -unavailable- added by dreamer_

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.


    Error: not logged in



    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed Oct 15 05:31:51 2014fendrinAssigned tofendrin=>None
    Fri Jul 5 07:48:05 2013vultrazAssigned toNone=>fendrin
    Fri Jul 5 04:27:31 2013dreamer_Attached File-=>Added 0001-Fix-error-handling-for-map-loading-when-screenshot-o.patch, #18202
      Carbon-Copy-=>Added thunderstruck
    Show feedback again

    Back to the top

    Powered by Savane 3.1-cleanup