patchFreeciv - Patches: patch #3987, Pointer to extra type to road/base...

 
 
Show feedback again

patch #3987: Pointer to extra type to road/base types

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Wed 10 Jul 2013 08:09:25 PM UTC  
 
Category: generalPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 14 Jul 2013 11:22:54 PM UTC, SVN revision 23043:

Added direct pointer from base_type and road_type structures to their extra_type.

See patch #3987

(Browse SVN revision 23043)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri 12 Jul 2013 09:00:42 PM UTC, comment #1:

- Const parameter to accessor functions

(file #18264)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 10 Jul 2013 08:09:25 PM UTC, original submission:

Currently it's somewhat costly to get extra_type from base_type or road_type with extra_type_get(). Attached patch adds direct pointer from base_type and road_type structures to their extra_type. No callers are touched to avoid conflicts with other patches currently being processed. New patches should use these new base_extra_get() and road_base_get() functions instead of extra_type_get() when appropriate.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #18264:  BaseroadExtraGet-2.patch added by cazfi (4kB - text/x-diff)
file #18241:  BaseroadExtraGet.patch added by cazfi (4kB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 14 Jul 2013 11:23:08 PM UTCcazfiStatusReady For Test=>Done
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Fri 12 Jul 2013 09:00:42 PM UTCcazfiAttached File-=>Added BaseroadExtraGet-2.patch, #18264
    Wed 10 Jul 2013 08:09:25 PM UTCcazfiAttached File-=>Added BaseroadExtraGet.patch, #18241
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup