patchFreeciv - Patches: patch #3990, Ruleset defined number of movement...

 
 
Show feedback again

patch #3990: Ruleset defined number of movement fragments

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Thu Jul 11 06:05:04 2013  
 
Category: generalPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.5.0, 2.6.0Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu Jul 18 22:37:34 2013, SVN revision 23066:

Made number of fragments each movement point is divided to ruleset defined.

See patch #3990

(Browse SVN revision 23066)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu Jul 18 22:37:28 2013, SVN revision 23065:

Made number of fragments each movement point is divided to ruleset defined.

See patch #3990

(Browse SVN revision 23065)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Tue Jul 16 08:37:35 2013, comment #2:

- Updated against svn.

(file #18286, file #18287)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu Jul 11 06:25:23 2013, comment #1:

I'd like to get this to S2_5 too (patch applies as is) despite it being potentially buggy for stable branch (do all places that should use SINGLE_MOVE do?)

With hardcoded SINGLE_MOVE of 3 there's not much space for defining rulesets with multiple roads as improvements over each other. In fact, if one wants each road to at least double the speed, there's only the classic ruleset route of (3/3 (no road) -> 1/3 (road) -> 0/3 (railroad)). This patch makes new generalized roads feature of 2.5 much more useful as one could have more granulanity in road movement cost (16/16 -> 8/16 -> 4/16 -> 2/16 -> 1/16 -> 0/16)

Further, if this is accepted, experimental ruleset could be tweaked to take advantage of it. Currently (2/3 (road) -> 1/3 (railroad) -> 0/3 (maglev)) i.e., road not even halving movement cost, could be (2/4 (road) -> 1/4 (railroad) -> 0/3 (maglev))

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu Jul 11 06:05:04 2013, original submission:

Make number of fragments each movement point is divided to (SINGLE_MOVE) ruleset defined. Also make number of fragments IgTer move takes ruleset configurable.

Compared to just making hardcoded SINGLE_MOVE bigger to always use higher resolution this approach has the benefits that movement costs can be shown in a way more meaningful for current ruleset ("1/3" instead of "33/100" as smallest possible value) and also those values can be used in ruleset definitions.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #18286:  MoveFragments-2.patch added by cazfi (13kB - text/x-diff)
file #18287:  MoveFragments-S2_5-2.patch added by cazfi (13kB - text/x-diff)
file #18248:  MoveFragments.patch added by cazfi (13kB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Error: not logged in

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu Jul 18 22:37:44 2013cazfiStatusReady For Test=>Done
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Tue Jul 16 08:37:35 2013cazfiAttached File-=>Added MoveFragments-2.patch, #18286
      Attached File-=>Added MoveFragments-S2_5-2.patch, #18287
    Thu Jul 11 06:25:23 2013cazfiPlanned Release2.6.0=>2.5.0, 2.6.0
    Thu Jul 11 06:05:04 2013cazfiAttached File-=>Added MoveFragments.patch, #18248
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup