patchFreeciv - Patches: patch #3991, silence a few gtk3 deprecation...

 
 
Show feedback again

patch #3991: silence a few gtk3 deprecation warnings

Submitted by:  Rafał Mużyło <galtgendo>
Submitted on:  Thu 11 Jul 2013 12:22:10 PM UTC  
 
Category: module installerPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.5.0, 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Mon 09 Sep 2013 08:25:59 PM UTC, comment #9:

> adds both gtk2, and gtk3 CFLAGS to AM_CPPFLAGS.


Now bug #21121

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 09 Sep 2013 08:19:45 PM UTC, comment #8:

> I see both -I/usr/include/gtk-2.0 and -I/usr/include/gtk-3.0 on
> my command line; has it picked up the wrong gtk/gtk.h?


I've realized that possibility (from sources, not from actual build) but it hasn't caused me any problems. Anyway that would be result from patch #4133 that adds both gtk2, and gtk3 CFLAGS to AM_CPPFLAGS.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 09 Sep 2013 08:15:54 PM UTC, comment #7:

... "--enable-fcmp=auto" builds freeciv-mp-gtk3 for me but doesn't fall over.

Jacob Nevins <jtn>
Project Administrator
Mon 09 Sep 2013 08:12:06 PM UTC, comment #6:

(I gave "--enable-fcmp=all" to configure, if that helps.)

Jacob Nevins <jtn>
Project Administrator
Mon 09 Sep 2013 08:11:15 PM UTC, comment #5:

After this change, my build (on Ubuntu Precise) seems to have fallen over in a heap.
I see both -I/usr/include/gtk-2.0 and -I/usr/include/gtk-3.0 on my command line; has it picked up the wrong gtk/gtk.h?

Jacob Nevins <jtn>
Project Administrator
Mon 09 Sep 2013 07:39:33 PM UTC, SVN revision 23327:

Fixed some deprecations from gtk3 version of freeciv-modpack.

Patch by Rafa?\197?\130 Mu?\197?\188y?\197?\130o with updates by me

See patch #3991

(Browse SVN revision 23327)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 09 Sep 2013 07:39:27 PM UTC, SVN revision 23326:

Fixed some deprecations from gtk3 version of freeciv-modpack.

Patch by Rafa?\197?\130 Mu?\197?\188y?\197?\130o with updates by me

See patch #3991

(Browse SVN revision 23326)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri 06 Sep 2013 11:03:38 PM UTC, comment #2:

Updated to apply to gtk3-version of modpack-installer with no version check as we already know it's gtk3-program.

(file #18903)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 02 Sep 2013 07:35:46 PM UTC, comment #1:

This patch has been pending while I wonder if we should have separete gtk2- and gtk3-modpack instead of current model where only one of them can be built.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu 11 Jul 2013 12:22:10 PM UTC, original submission:

This patch silences a few gtk3 deprecation warnings from freeciv-modpack.
It's against S2_5, but (IIRC) will apply cleanly to S2_4 too (after path changes, that is).

I wonder though, if the button is that wide per design or just cause it was packed this way.

Rafał Mużyło <galtgendo>

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jtn (Posted a comment)
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by galtgendo (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 09 Sep 2013 07:39:44 PM UTCcazfiStatusReady For Test=>Done
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Fri 06 Sep 2013 11:03:38 PM UTCcazfiAttached File-=>Added Fcmpgtk3Depr.patch, #18903
      StatusNone=>Ready For Test
      Planned Release=>2.5.0, 2.6.0
    Thu 11 Jul 2013 12:22:10 PM UTCgaltgendoAttached File-=>Added 0001-silence-gtk3-deprecation-warnings-in-modinst.c.patch, #18253
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup