patchFreeciv - Patches: patch #4005, Extras vector

 
 
Show feedback again

patch #4005: Extras vector

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Mon Jul 15 23:10:48 2013  
 
Category: generalPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.6.0Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon Jul 22 19:47:08 2013, SVN revision 23095:

Replaced tile special, base, and road vectors with single extras vector.

See patch #4005

(Browse SVN revision 23095)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun Jul 21 20:23:25 2013, comment #4:

Autogame generated savegames differ, but it turned out it's actually problem in old savegame format. Games are identical, but old savegames occasionally have some of the padding bits in the end of extras vector set (classic ruleset has 13 = 4+4+4+1 extras, so last hex has just one significant bit).

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat Jul 20 03:13:59 2013, comment #3:

tile resource_valid could end FALSE in startpos generation. Before this patch it was restored as part of specials bitvector, but nothing resotres it as separate value in ver 3 of this patch. Patch #4023 address this.

- Updated to apply on top of current svn + patch #4023

(file #18360)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed Jul 17 21:16:39 2013, comment #2:

- Updated against svn

(file #18323)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Tue Jul 16 20:02:15 2013, comment #1:

- Updated against Qt-client changes

(file #18295)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon Jul 15 23:10:48 2013, original submission:

Replace tile special, base, and road vectors with extras vector. Changed all the functions that wanted to take those individual vectors from tile to take extras vector as parameter.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #18360:  ExtrasVector-4.patch.bz2 added by cazfi (16kB - application/x-bzip)
file #18323:  ExtrasVector-3.patch.bz2 added by cazfi (17kB - application/x-bzip)
file #18295:  ExtrasVector-2.patch.bz2 added by cazfi (17kB - application/x-bzip)
file #18285:  ExtrasVector.patch.bz2 added by cazfi (16kB - application/x-bzip)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Error: not logged in

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon Jul 22 19:47:20 2013cazfiStatusReady For Test=>Done
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Sat Jul 20 03:13:59 2013cazfiAttached File-=>Added ExtrasVector-4.patch.bz2, #18360
    Wed Jul 17 21:16:39 2013cazfiAttached File-=>Added ExtrasVector-3.patch.bz2, #18323
    Tue Jul 16 20:02:15 2013cazfiAttached File-=>Added ExtrasVector-2.patch.bz2, #18295
    Mon Jul 15 23:10:48 2013cazfiAttached File-=>Added ExtrasVector.patch.bz2, #18285
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup