patchFreeciv - Patches: patch #4016, Qt::global code style fixup

 
 
Show feedback again

patch #4016: Qt::global code style fixup

Submitted by:  mir3x <mir3x>
Submitted on:  Wed 17 Jul 2013 06:43:30 PM UTC  
 
Category: client-qtPriority: 3 - Low
Status: DonePrivacy: Public
Assigned to: mir3x <mir3x>Open/Closed: Closed
Planned Release: 2.5.0 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Tue 23 Jul 2013 09:02:45 PM UTC, SVN revision 23100:

Fixed lack of updating map when mapview recentering time was 0.
Also fixed civilization information, which was displayed incorrectly after
last patch([patch #4016] Qt::global code style fixup).

See gna patch #4026

(Browse SVN revision 23100)

mir3x <mir3x>
Project MemberIn charge of this item.
Tue 23 Jul 2013 09:01:28 PM UTC, SVN revision 23098:

Fixed lack of updating map when mapview recentering time was 0.
Also fixed civilization information, which was displayed incorrectly after
last patch([patch #4016] Qt::global code style fixup).

See gna patch #4026

(Browse SVN revision 23098)

mir3x <mir3x>
Project MemberIn charge of this item.
Fri 19 Jul 2013 01:03:39 PM UTC, SVN revision 23073:

Fixed some code style in all files:
mostly:
-brackets and xxx_itereate_end macro
-empty lines after variables
-moved variables to the beggining of block

See gna patch #4016

(Browse SVN revision 23073)

mir3x <mir3x>
Project MemberIn charge of this item.
Fri 19 Jul 2013 01:03:14 PM UTC, SVN revision 23072:

Fixed some code style in all files:
mostly:
-brackets and xxx_itereate_end macro
-empty lines after variables
-moved variables to the beggining of block

See gna patch #4016

(Browse SVN revision 23072)

mir3x <mir3x>
Project MemberIn charge of this item.
Fri 19 Jul 2013 07:47:01 AM UTC, comment #3:

It seems patch #4005 needs some work in any case (it didn't pass my autogame testing) so feel free to go forward with this meanwhile.

Marko Lindqvist <cazfi>
Project Administrator
Thu 18 Jul 2013 07:09:38 AM UTC, comment #2:

I'll wait until both will be committed and I'll modify that one before committing.

mir3x <mir3x>
Project MemberIn charge of this item.
Wed 17 Jul 2013 09:26:52 PM UTC, comment #1:

For such patch touching a bit every place in Qt-client we need to synchronize a bit to avoid patch conflicts. I just committed patch #4002 that touched Qt-client code. I also just updated patch #4005 that will touch Qt-client, but decided not to make it to apply on top of this one - either one needs to be changed to apply on top of the other. I'd like #4005 to go in first, as it's so important step in extras implementation on top of which to build further development. It's also huge patch that would easily suffer bitrot from almost any part of the code, not just Qt-client. Any further patches I'd make so that they apply on top of this one.

Marko Lindqvist <cazfi>
Project Administrator
Wed 17 Jul 2013 06:43:30 PM UTC, original submission:

Fixed some code style in all files:
mostly:
-brackets and xxx_itereate_end macro
-empty lines after variables
-moved variables to the beggining of block

mir3x <mir3x>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by mir3x (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 19 Jul 2013 01:04:39 PM UTCmir3xStatusReady For Test=>Done
      Assigned toNone=>mir3x
      Open/ClosedOpen=>Closed
    Wed 17 Jul 2013 06:43:30 PM UTCmir3xAttached File-=>Added Qt-global-codestyle-fixup-S25.patch.bz2, #18319
      Attached File-=>Added Qt-global-codestyle-fixup-S26.patch.bz2, #18320
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup