patchFreeciv - Patches: patch #4084, Windows packages follow tag...

Show feedback again

patch #4084: Windows packages follow tag insufficiently precise

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Sun Aug 11 10:49:27 2013  
Category: clientPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.5.0-beta1Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):

You are not logged in

Please log in, so followups can be emailed to you.


Sat Aug 24 21:15:26 2013, SVN revision 23229:

Use follow tag "win32-S2_5" in beta builds of windows installer in S2_5 branch.

See patch #4084

(Browse SVN revision 23229)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed Aug 21 20:07:18 2013, comment #4:

> That should be documented in appropriate instructions.

I've updated and also added a commented-out 'win32-S2_5' line to versions.php on the metaserver.

Jacob Nevins <jtn>
Project Administrator
Wed Aug 21 09:54:31 2013, comment #3:

Attached patch changes tag used in windows package build for S2_5. I think this should go in now so that any build made from S2_5 will get that tag, and in future branches this kind of change should be made as part of branching itself.

Now, we have to remember change it back to stable tag "win32" just before releasing 2.5.0-RC1. That should be documented in appropriate instructions.

(file #18725)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Tue Aug 20 09:11:58 2013, comment #2:

Ah, yes, that makes sense.
So, the action is to change the follow tag included in Windows builds to "win32-S2_5" before 2.5.0-beta1 (and add that tag to the metaserver).
Retargeting appropriately.

Jacob Nevins <jtn>
Project Administrator
Fri Aug 16 22:30:36 2013, comment #1:

My original idea was that basic "win32" is windows builds equivalent to "stable" (reverse-engineering even further: default should be empty string, but due to technical limitatios we can't have that. So we have "stable". "win32" is not empty string so there's no need to make it "win32-stable").
So, we wouldn't give tag "win32" to 2.5 betas or release candidates (maybe "win32-S2_5" there?) but only to 2.5.0 final.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun Aug 11 10:49:27 2013, original submission:

Currently, Windows packages all use the "win32" follow tag to notify users of new releases.

Follow tags are new to 2.4, so the fact that this is currently set to "2.4.0-beta2" is not a problem; it would make no sense for it to say "2.3.4", since the only clients that take notice are newer than 2.3.x.

However, once a stable release of 2.4.x is out, then if we carry on the policy of having a single "win32" tag, then as soon as 2.5.0 betas are released, stable 2.4.x users will be encouraged to upgrade to them, which is probably not what we want; I think stable 2.4.x users should only be bothered when 2.5.0 is released. (This is what people who build from source will see, due to separate "stable" and "S2_5" follow tags.)

Perhaps we should make Windows builds use a followtag of "win32-${DEFAULT_FOLLOW_TAG}" or similar (giving "win32-stable", "win32-S2_4").

Probably need to resolve this for the next 2.4.0 build (RC or stable release), but I won't hold up RC1 for it.

Jacob Nevins <jtn>
Project Administrator


(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):

Attached Files
file #18725:  Win32-S2_5Tag.patch added by cazfi (576B - text/x-diff)


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by jtn (Submitted the item)

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.


    Error: not logged in



    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat Aug 24 21:16:01 2013cazfiStatusReady For Test=>Done
      Assigned toNone=>cazfi
    Wed Aug 21 09:54:31 2013cazfiAttached File-=>Added Win32-S2_5Tag.patch, #18725
      StatusNeed Info=>Ready For Test
    Tue Aug 20 09:11:58 2013jtnPlanned Release2.4.0=>2.5.0-beta1
    Show feedback again

    Back to the top

    Powered by Savane 3.1-cleanup