patchFreeciv - Patches: patch #4101, Ability for bases to hide units

 
 
Show feedback again

patch #4101: Ability for bases to hide units

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Wed Aug 21 19:43:28 2013  
 
Category: generalPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 3.0.0Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sun Nov 13 10:42:35 2016, SVN revision 34494:

Added support for extras that can hide units inside from opponents.

Requested by Jacob Nevins

See patch #4101

(Browse SVN revision 34494)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri Nov 11 06:32:30 2016, comment #5:

- Made the rulesave.c to save these rules

(file #29364)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Tue Nov 8 12:51:38 2016, comment #4:

- Ruleset comments added
- Extra appearance/disappearance and owner change handled

(file #29340)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun Oct 30 22:49:38 2016, comment #3:

WIP patch

Missing:
- Ruleset comments
- Handling of units on tile when extra appearas/disappears, extra_owner changes, or alliance status between players changes

(file #29192)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu Sep 19 00:17:06 2013, comment #2:

I think one could try to make first version of this already, with improvements in later tickets.
- "Nativity" is now property of extras.
- Gfx tags are not property of extras, so changing the appearcanse of the extra depending if it hides units or not, cannot be yet implemented

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu Aug 22 12:12:36 2013, comment #1:

In general I would not implement new base-specific (or road-specific) features. In most cases that's just more work for us to generalize to all extras later. Also, some rulesets already have Tunnels and Ocean Tubes kind of road types that could quite logically hide the units traveling them. This means that this feature would need to wait a bit that it can be added to extras instead of just bases.

First of all, "nativity", should be property of extras, not just bases and roads. That's needed to know which units the extra will hide (which units are inside it - fortress not hiding units flying over it)
Graphics tags should be ruleset defined for extras instead of just bases and roads with others using hardcoded tags. This is needed for adding the "occupied" tag.

I'm already working on these dependency patches.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed Aug 21 19:43:28 2013, original submission:

User "begre1929" asks on the forum:

"I have a question about the base, in civilization 2, the airbase hid the airplanes presently on the tile, is it possible to do that in Freeciv ? I would like to hide my unit in the castles."

I don't think this is possible currently, but it seems like a reasonable feature request.

In principle it shouldn't be too hard since we already have similar code for cities. But I think there are lots of fiddly special cases to do with units coming into / going out of sight, so I bet it takes a while to stabilise.

Another thing to consider is whether indicating the presence of some units is a sub-option (like the city occupied sprite) -- either units in a base are completely invisible, or you can tell there are some units but not how many or what there are.

(I haven't been keeping up with "extras", so I don't know whether it still makes sense for this to be base-specific. You could imagine terrain features hiding units too.)

For the avoidance of doubt, I have no imminent plans to implement this -- feel free to grab it.

Jacob Nevins <jtn>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #29364:  UnitHidingExtras-3.patch added by cazfi (21kB - text/plain-diff)
file #29340:  UnitHidingExtras-2.patch added by cazfi (21kB - text/plain-diff)
file #29192:  UnitHidingExtras.patch added by cazfi (8kB - text/plain-diff)

 

Depends on the following items: None found

Digest:
   task dependencies.

 

Carbon-Copy List
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Error: not logged in

     

     

    Follow 12 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun Nov 13 10:42:45 2016cazfiStatusReady For Test=>Done
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Fri Nov 11 06:32:30 2016cazfiAttached File-=>Added UnitHidingExtras-3.patch, #29364
    Tue Nov 8 12:51:38 2016cazfiAttached File-=>Added UnitHidingExtras-2.patch, #29340
      StatusIn Progress=>Ready For Test
    Sun Oct 30 22:49:38 2016cazfiAttached File-=>Added UnitHidingExtras.patch, #29192
      StatusNone=>In Progress
    Thu Jan 21 07:24:08 2016cazfiPlanned Release=>3.0.0
    Thu Sep 18 01:24:23 2014cazfiPlanned Release2.6.0=>
    Thu Aug 22 12:12:36 2013cazfiCategoryNone=>general
      Planned Release=>2.6.0
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup