patchrelax - Patches: patch #4130, Extended system test for providing...

 
 
Show feedback again

You are not allowed to post comments on this tracker with your current authentification level.

patch #4130: Extended system test for providing list of spectra ID for NMRPipe seriesTab

Submitted by:  Troels E. Linnet <tlinnet>
Submitted on:  Mon 02 Sep 2013 10:48:09 AM UTC  
 
Category: NonePriority: 3 - Low
Status: NoneAssigned to: None
Open/Closed: Open

Mon 02 Sep 2013 12:25:54 PM UTC, comment #1:

This patch does not change the test. It passes before and after applying the patch. What is the purpose of this addition? Why is it part of an existing test and not a new test? Are you trying to replicate bug #21076 (http://gna.org/bugs/?21076)?

Note that the patch is missing a newline at the end - there should be 2 empty lines between functions/methods.

Edward d Auvergne <bugman>
Project Administrator
Mon 02 Sep 2013 10:48:09 AM UTC, original submission:

Adding patch for extended system test for providing list of spectra ID for NMRPipe seriesTab.

The key is to also provide a list of integers for "int_col=list(range(len(spectra_ID)))".

The int_col is not used in NMRPipe Seriestab, but in the generic format.

I have looked into fixing this input test, but were not able to figure out a reasonable alternative.

I seems reasonable expect this input, as NMRPipe seriestab could later be extended to exclude loading of some columns intensity.

Troels E. Linnet <tlinnet>
Project Member

 

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bugman (Posted a comment)
  • -unavailable- added by tlinnet (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follows 1 latest change.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 02 Sep 2013 10:48:09 AM UTCtlinnetAttached File-=>Added 0001-Extended-system-test-for-providing-list-of-spectra-I.patch, #18828
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup