patchFreeciv - Patches: patch #4131, Oil Well

 
 
Show feedback again

patch #4131: Oil Well

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Mon 02 Sep 2013 03:46:35 PM UTC  
 
Category: generalPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 25 Dec 2013 12:08:06 PM UTC, SVN revision 23896:

Added Oil Well extra for classic, experimental, multiplayer, and civ2civ3 rulesets.

See patch #4131

(Browse SVN revision 23896)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 18 Dec 2013 09:17:29 PM UTC, comment #4:

People have been wanting to keep Oil Derrick gfx for Glacier/Desert Mines, so here's Oil Well patch again. This time it's ruleset (and tileset) patch only, we're no longer restricted to hardcoded number of slots for specials kind of extras.

I think there's one behavior change: If terrain changes between types of which one can support Mine and the other Oil Well, extra is lost.

(file #19487)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 02 Sep 2013 11:47:24 PM UTC, comment #3:

> it's always bothered me to see desert derricks built by
> civilisations that haven't yet discovered the wheel.


Me too, but I have assumed I'm the only one as that's the way it's been done.

> this doesn't seem like a good enough reason to change gameplay


Not gameplay, but how about gfx? Maybe we should not introduce Oil Well to any of the supplied rulesets, but use Mine gfx on deserts too?

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 02 Sep 2013 11:35:07 PM UTC, comment #2:

Cosmetic digression: it's always bothered me to see desert derricks built by civilisations that haven't yet discovered the wheel.
I don't think I have a constructive suggestion; this doesn't seem like a good enough reason to change gameplay by restricting Oil Well to needing some plausible prerequisite tech (prior to which you can't mine deserts/ice at all). There may be other, better reasons for doing so.

Jacob Nevins <jtn>
Project Administrator
Mon 02 Sep 2013 10:09:50 PM UTC, comment #1:

Patch.

Oil Well added to classic, multiplayer, civ2civ3, and experimental rulesets. civ1, civ2, and alien use same mine sprite everywhere.

(file #18833)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 02 Sep 2013 03:46:35 PM UTC, original submission:

There will be tileset related reggression because of generic extras. Currently one can define sprites for Mine separately for each terrain. Once the tag definition is moved to extra definition in ruleset, there can be just one tag common to all terrains for each extra.
Supplied tilesets use the old feature to have two kinds of mine gfx: Mine and Oil Well.
This ticket is about mitigating the problem by adding separate Oil Well extra, so tilesets can still have those two traditional sprites for mines. As number of extras cannot be made dynamic before gfx tags are read from extra definition, and gfx tags cannot be moved to extra definitions before Oil Well is added, this needs to go in as hardcoded special first.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #19487:  OilWell-2.patch added by cazfi (16kB - text/x-diff)
file #18833:  OilWell.patch added by cazfi (17kB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jtn (Posted a comment)
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 25 Dec 2013 12:08:16 PM UTCcazfiStatusReady For Test=>Done
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Wed 18 Dec 2013 09:17:29 PM UTCcazfiAttached File-=>Added OilWell-2.patch, #19487
      StatusIn Progress=>Ready For Test
    Wed 18 Sep 2013 11:18:39 AM UTCcazfiStatusReady For Test=>In Progress
    Mon 02 Sep 2013 10:09:50 PM UTCcazfiAttached File-=>Added OilWell.patch, #18833
      StatusIn Progress=>Ready For Test
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup