patchFreeciv - Patches: patch #4139, tile_extra_apply() to handle...

 
 
Show feedback again

patch #4139: tile_extra_apply() to handle recursive extra requirements

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Tue 03 Sep 2013 09:47:45 PM UTC  
 
Category: generalPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 08 Sep 2013 05:41:05 PM UTC, SVN revision 23318:

- Moved add_recursive_extras() from server/edithand.c to common/tile.c
- Made tile_extra_apply() to add requirement extras with add_recursive_extras()
- Call tile_extra_apply() instead of add_recursive_extras() from editor code

See patch #4139

(Browse SVN revision 23318)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri 06 Sep 2013 03:11:44 PM UTC, comment #3:

> Is that documentation good enough?

Yes.

Sveinung Kvilhaugsvik <sveinung>
Project Member
Fri 06 Sep 2013 02:47:44 PM UTC, comment #2:

- Added explanation about partial adjustments in case of failure to tile_extra_apply() function header.

Is that documentation good enough?

(file #18898)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 04 Sep 2013 08:01:50 PM UTC, comment #1:

Should its behavior when some branches of the dependency tree can be added and others not be documented?

Sveinung Kvilhaugsvik <sveinung>
Project Member
Tue 03 Sep 2013 09:47:45 PM UTC, original submission:

- Move add_recursive_extras() from server/edithand.c to common/tile.c
- Made tile_extra_apply() to add requirement extras with add_recursive_extras()
- Call tile_extra_apply() instead of add_recursive_extras() from editor code

This means both that also old callers of tile_extra_apply() get requirement handling too, and editor code gets conflicts handling that was already present in tile_extra_apply(). Latter is real, functional, user-visible change, while latter is more theoretical with current callers.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #18850:  TileExtraApplyDeps.patch added by cazfi (4kB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by sveinung (Posted a comment)
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 08 Sep 2013 05:41:17 PM UTCcazfiStatusReady For Test=>Done
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Fri 06 Sep 2013 02:47:44 PM UTCcazfiAttached File-=>Added TileExtraApplyDeps-2.patch, #18898
    Tue 03 Sep 2013 09:47:45 PM UTCcazfiAttached File-=>Added TileExtraApplyDeps.patch, #18850
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup