patchFreeciv - Patches: patch #4141, destroy_extra()

 
 
Show feedback again

patch #4141: destroy_extra()

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Wed 04 Sep 2013 12:19:03 AM UTC  
 
Category: generalPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 09 Sep 2013 07:04:22 PM UTC, SVN revision 23325:

Renamed destroy_base() as destroy_extra() and made it to handle any kind of extras.
Changed users to take advantage of that.

See patch #4141

(Browse SVN revision 23325)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 07 Sep 2013 09:31:23 PM UTC, comment #1:

- Do not call extra_base_get() before you are sure extra in question is base. While it returns NULL as expected in that case, it also asserts against the input (and I want to keep that assert)

(file #18920)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 04 Sep 2013 12:19:03 AM UTC, original submission:

Rename destroy_base() as destroy_extra() and make it to handle any kind of extras. Change users to take advantage of that.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #18920:  DestroyExtra-2.patch added by cazfi (8kB - text/x-diff)
file #18856:  DestroyExtra.patch added by cazfi (8kB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 09 Sep 2013 07:04:33 PM UTCcazfiStatusReady For Test=>Done
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Sat 07 Sep 2013 09:31:23 PM UTCcazfiAttached File-=>Added DestroyExtra-2.patch, #18920
    Wed 04 Sep 2013 12:19:03 AM UTCcazfiAttached File-=>Added DestroyExtra.patch, #18856
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup