patchFreeciv - Patches: patch #4143, Notify player about incompatible...

 
 
Show feedback again

patch #4143: Notify player about incompatible tileset

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Wed 04 Sep 2013 08:31:20 AM UTC  
 
Category: clientPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.5.0, 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Mon 07 Oct 2013 11:06:09 PM UTC, SVN revision 23543:

Show error message dialog about tileset errors in gtk-clients.
Client will shut down only once user closes that dialog.

See patch #4143

(Browse SVN revision 23543)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 07 Oct 2013 11:06:02 PM UTC, SVN revision 23542:

Show error message dialog about tileset errors in gtk-clients.
Client will shut down only once user closes that dialog.

See patch #4143

(Browse SVN revision 23542)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 02 Oct 2013 09:06:14 PM UTC, comment #5:

- Updated against svn
- Also log messages
- Check log level within tileset_error() so that loggin happens always, gui dialog only on error levels

(file #19125)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 30 Sep 2013 01:23:55 PM UTC, comment #4:

- Especially since some clients do not implement the error dialog, it should not completely replace old logging of the errors.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 30 Sep 2013 01:11:20 PM UTC, comment #3:

S2_5 version

(file #19115)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 30 Sep 2013 12:05:10 PM UTC, comment #2:

Attached patch for TRUNK makes gtk-clients to show error message dialog for tileset errors. Client will shut down only once user closes that dialog.

As error messages come more user-visible (not hidden to logfiles only), I made all of them translatable. We may want to reconsider that for more obscure ones at least.

(file #19114)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 04 Sep 2013 11:40:51 AM UTC, comment #1:

Somewhat related to patch #4043

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 04 Sep 2013 08:31:20 AM UTC, original submission:

Client shuts down when tileset is incompatible with ruleset. Most frequently this happens when one connects to server that sends new rulesets. Client informs user only in console logging. For someone who has not launched client from commandline it seems that client simply crashes when ever it connects to server.
We really should at least notify user in accessible way why client is closing so they know to use correct tileset next time.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #19125:  TilesetError-2.patch added by cazfi (19kB - text/x-diff)
file #19115:  TilesetError-S2_5.patch added by cazfi (19kB - text/x-diff)
file #19114:  TilesetError.patch added by cazfi (20kB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 9 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 07 Oct 2013 11:06:19 PM UTCcazfiStatusReady For Test=>Done
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Wed 02 Oct 2013 09:06:14 PM UTCcazfiAttached File-=>Added TilesetError-2.patch, #19125
      StatusIn Progress=>Ready For Test
    Mon 30 Sep 2013 01:23:55 PM UTCcazfiStatusReady For Test=>In Progress
    Mon 30 Sep 2013 01:11:20 PM UTCcazfiAttached File-=>Added TilesetError-S2_5.patch, #19115
      StatusIn Progress=>Ready For Test
    Mon 30 Sep 2013 12:05:10 PM UTCcazfiAttached File-=>Added TilesetError.patch, #19114
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup